Fix iterations.php request for login

lastpass / lastpass-cli

LastPass command line interface tool

GNU General Public License v2.0

2.85k stars 290 forks source link

Fix iterations.php request for login #605

Closed brendanlong closed 2 months ago

brendanlong commented 3 years ago

For some reason iterations.php only works with GET requests now and is flaky, so this:

Fixes the error message when there's no error cause field so it actually shows something instead of "unknown"
Uses a request to login.php to get the number of iterations

Fixes https://github.com/lastpass/lastpass-cli/issues/604

rkirkpat commented 3 years ago

Appears the CI build and test has bit-rotted, failures are due to apt and brew errors it appears.

Was able to apply with brew, build, and verify it fixed the iterations.php breakage, see: https://github.com/lastpass/lastpass-cli/issues/604#issuecomment-843612877

brendanlong commented 3 years ago

I updated this to use login.php since the previous version using iterations.php didn't work for everyone.

crispjw commented 1 year ago

I recently updated my Password Iterations to 310,000 per OWASP recommendations and that broke the lpass command line for me. When I rebuilt lastpass with this code fix, the lpass command line works again. Thanks!

0xdevalias commented 2 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

0xdevalias commented 2 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

Hello @0xdevalias. The Pull Requests were closed unintentionally. By tomorrow I will be sure to leave a message on how to proceed. My sincere apologies for the inconvenience.

Originally posted by @mateusmartins-lp in https://github.com/lastpass/lastpass-cli/issues/553#issuecomment-2098844351

mateusmartins-lp commented 1 month ago

Regrettably, your PR submission was unintentionally closed during an operation, before we could complete our review and respond accordingly. Unable to revert it to 'Open' status, we invite you to resubmit your contribution at your earliest convenience. We apologize for this mishap. Rest assured, we value all contributions and remain dedicated to providing transparency and closure to the community. Thank you for your understanding.