search

lastpass / lastpass-cli

LastPass command line interface tool
GNU General Public License v2.0
2.85k stars 290 forks source link

Password History #628

Closed boginw closed 2 months ago

boginw commented 2 years ago

This PR introduces a new subcommand with the ability to fetch password history from the API. This closes #245.

Discussion points:

As far as I know, it is not possible to retrieve the history from the cache, so a call is needed for every password history retrieval. Adding this as an option to show or ls seemed like it would produce a lot of unnecessary calls, which is why it was made into a new subcommand.

In order to parse the results from the API, a third-party library JSON parser was added (tiny-json). However, given that the current requirements only include JSON types of objects, arrays, and strings, there might be room for optimization.

Fire-Dragon-DoL commented 1 year ago

Hello, given the recent breach this Pull request is suddenly important. LastPass, can you please get this verified and merged?

Fire-Dragon-DoL commented 1 year ago

In case somebody else end up on this PR, I forked it and added support for shared folders (it's hacky) and included a script to download the entire password history: https://github.com/lastpass/lastpass-cli/issues/245#issuecomment-1366526206

boginw commented 1 year ago

Hi @Fire-Dragon-DoL and happy holidays :tada:

Thanks for your interest in this PR. Unfortunately, LastPass very rarely commits to this repo anymore. I wouldn't get my hopes up if I were you.

P.S.: The link in your comment (https://github.com/Fire-Dragon-DoL/lastpass-cli-history) is dead. Maybe the repo is private?

Fire-Dragon-DoL commented 1 year ago

Hi @Fire-Dragon-DoL and happy holidays 🎉

Thanks for your interest in this PR. Unfortunately, LastPass very rarely commits to this repo anymore. I wouldn't get my hopes up if I were you.

P.S.: The link in your comment (https://github.com/Fire-Dragon-DoL/lastpass-cli-history) is dead. Maybe the repo is private?

Yes! Thank you for the response, I made it public.

As I reported, it's hacky, I don't use C often, plus reverse-engineering lastpass wasn't really my plan for the holidays, so I brought it where it was functional enough for me to run the backup.

waterkip commented 1 year ago

@Fire-Dragon-DoL maybe we can combine forces: https://github.com/lastpass-cli-fork/lastpass-cli

Fire-Dragon-DoL commented 1 year ago

@Fire-Dragon-DoL maybe we can combine forces: https://github.com/lastpass-cli-fork/lastpass-cli

Appreciate the offer, but I performed my migration and I'm ready to move on, I don't plan to continue using LastPass for the foreseeable future.

0xdevalias commented 2 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

0xdevalias commented 2 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

Hello @0xdevalias. The Pull Requests were closed unintentionally. By tomorrow I will be sure to leave a message on how to proceed. My sincere apologies for the inconvenience.

Originally posted by @mateusmartins-lp in https://github.com/lastpass/lastpass-cli/issues/553#issuecomment-2098844351

mateusmartins-lp commented 1 month ago

Regrettably, your PR submission was unintentionally closed during an operation, before we could complete our review and respond accordingly. Unable to revert it to 'Open' status, we invite you to resubmit your contribution at your earliest convenience. We apologize for this mishap. Rest assured, we value all contributions and remain dedicated to providing transparency and closure to the community. Thank you for your understanding.