Parameter note-type not reflected, always got secure note despite `--note-type=Database` was specified

lastpass / lastpass-cli

LastPass command line interface tool

GNU General Public License v2.0

2.86k stars 291 forks source link

Parameter note-type not reflected, always got secure note despite `--note-type=Database` was specified #681

Open J0zi opened 7 months ago

J0zi commented 7 months ago

Hi, I want a DB secret to be stored in LastPass

executing printf "Username: jozef.test\nPassword: somepw" | lpass add --non-interactive --note-type=Database "Shared-user-jozef/database/some-cluster11" --sync=now

Result is a secure note:

Expected Database type:

I suppose that --note-type=Database will create a Database note type, however it created NoteType:Database entry under Notes

An older version was creating correct Database entries, not sure which one.

LastPass CLI v1.3.6.9.g1cdf78c

eldadpuzach commented 5 months ago

Same here with LastPass CLI v1.5.0.GIT Old version worked correctly: lastpass-cli-1.3.3

lukas-we commented 4 months ago

Since I also face this problem, I had a look at it with git bisect. It seems that MR #679 introduced the regression. Specifically one of the following commits:

2a87b15c28ae689d35968337623692e95bfc0d02
36f9ba27c80886db31a9af1529535fc1458f16ab
6d723c68ce4215373add03384265def5040b5249
54b38836aa8f0e56b6e5de8a7b77e5f9c1c38d36
fb245646c925dbdccb73d6bc7093875530654e35
319f45d73d743faef58b7534f7ee27276fef3b92 I was not able to narrow it down any further, since lpass would not synchronize with the server (presumably; the password would not show up in my vault).

HampusRosenquist commented 1 week ago

I am encountering the same problem, the only difference being that I try to add an SSH entry, using note type: --note-type=ssh-key. This used to work, but doesn't work on version 1.5.0 or 1.6.0.

EDIT: The most recent version that works for me is v1.3.7: https://github.com/lastpass/lastpass-cli/releases/tag/v1.3.7