lastpass / lastpass-cli

LastPass command line interface tool
GNU General Public License v2.0
2.86k stars 291 forks source link

Build failure with GCC 14 #693

Open lamby opened 4 months ago

lamby commented 4 months ago

Hi there,

Debian maintainer here. lastpass-cli currently fails to build under GCC 14. Although Debian may be applying more aggressive compiler flags, it does currently build with GCC 13.

Here is an excerpt:

/tmp/buildd/lastpass-cli-1.5.0/test/http_mock.c: In function 'init_test_data':
/tmp/buildd/lastpass-cli-1.5.0/test/http_mock.c:90:72: error: passing argument 4 of 'account_set_url' from incompatible pointer type [-Wincompatible-pointer-types]
   90 |         account_set_url(account, "https://test-url.example.com/", key, &feature_flag);
      |                                                                        ^~~~~~~~~~~~~
      |                                                                        |
      |                                                                        struct feature_flag **
In file included from /tmp/buildd/lastpass-cli-1.5.0/test/http_mock.c:40:
/tmp/buildd/lastpass-cli-1.5.0/test/../blob.h:169:124: note: expected 'const struct feature_flag *' but argument is of type 'struct feature_flag **'
  169 | void account_set_url(struct account *account, char *url, unsigned const char key[KDF_HASH_LEN], const struct feature_flag *feature_flag);
      |                                                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
/tmp/buildd/lastpass-cli-1.5.0/test/http_mock.c:100:52: error: passing argument 4 of 'account_set_url' from incompatible pointer type [-Wincompatible-pointer-types]
  100 |         account_set_url(account, "http://sn", key, &feature_flag);
      |                                                    ^~~~~~~~~~~~~
      |                                                    |
      |                                                    struct feature_flag **
/tmp/buildd/lastpass-cli-1.5.0/test/../blob.h:169:124: note: expected 'const struct feature_flag *' but argument is of type 'struct feature_flag **'
  169 | void account_set_url(struct account *account, char *url, unsigned const char key[KDF_HASH_LEN], const struct feature_flag *feature_flag);
      |                                                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
/tmp/buildd/lastpass-cli-1.5.0/test/http_mock.c:114:72: error: passing argument 4 of 'account_set_url' from incompatible pointer type [-Wincompatible-pointer-types]
  114 |         account_set_url(account, "https://test-url.example.com/", key, &feature_flag);
      |                                                                        ^~~~~~~~~~~~~
      |                                                                        |
      |                                                                        struct feature_flag **

… but a full build log is available.