backtrace--print-frame was deleted in emacs 27+, use alternate.

lastquestion / explain-pause-mode

top, but for Emacs.

GNU General Public License v3.0

240 stars 6 forks source link

backtrace--print-frame was deleted in emacs 27+, use alternate. #70

Closed lastquestion closed 4 years ago

lastquestion commented 4 years ago

This should have been caught via unit tests, and it did, I just didn't actually set the env-var for the unit test run correctly. I will automate that in another PR.

I decided to (require 'backtrace) dynamically, only when we actually need it, as it's not defined in emacs 26. In some future world when 26 support is dead (4 years from now?) I will move it to the top level requires.

The commit is https://github.com/emacs-mirror/emacs/commit/83af893fc0e7cc87c0fb0626fb48ef96e00b3f8b

lastquestion commented 4 years ago

I tried to make this more elegant via some eval-when-compile but I couldn't get it to work as I understand it. I'll try again later but I want to fix this bug first.