laszlojakab / homeassistant-easycontrols

Helios EasyControls Modbus TCP/IP integration for Home Assistant
MIT License
21 stars 12 forks source link

External Temp/Humidity Sensors FTF1 and FTF2 added #99

Closed Oandr closed 4 months ago

Oandr commented 1 year ago

This adds 2 KWL-FTF combined temp/humidity sensors to the framework. It adds configurations to: const.py coordinator.py sensor.py

laszlojakab commented 4 months ago

Thanks for the PR. Maybe it would be a good idea to add all the 8 external sensors (not just two) and also add VOC and CO₂ sensors beside temperature and humidity.

Also have to note one more thing based on the specs:

R: If val >= 9999 then '-'

So probably the sensor state should be unavailable when the value is 9999.

Do you have time make these changes?

laszlojakab commented 4 months ago

Related issue #92

laszlojakab commented 4 months ago

I have added all sensors except VOC and CO2 (I would like to find out the unit of measurement before adding) here: https://github.com/laszlojakab/homeassistant-easycontrols/tree/feat/add-external-sensors

laszlojakab commented 4 months ago

Implemented more sensors in PR #113