laszukdawid / PyEMD

Python implementation of Empirical Mode Decompoisition (EMD) method

https://pyemd.readthedocs.io/

Apache License 2.0

867 stars 224 forks source link

#104 - Added IMF significancetest for whitenoisecheck #105

Closed oshin94 closed 2 years ago

oshin94 commented 2 years ago

Hi @laszukdawid, Kindly see if the significancetest addition has been properly made. I have made it to the best of my capabilities however it will be helpful if you can share your thoughts on it and scrutinize it further. I am sure it can be further improved. Do let me know if you need any clarfications on this.

Cheers, oshin94

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (845c88f) into master (717a647) will decrease coverage by 7.00%. The diff coverage is 13.25%.

:exclamation: Current head 845c88f differs from pull request most recent head c18e628. Consider uploading reports for the commit c18e628 to get more accurate results

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   86.96%   79.95%   -7.01%     
==========================================
  Files           7        8       +1     
  Lines         790      873      +83     
  Branches      128      142      +14     
==========================================
+ Hits          687      698      +11     
- Misses         64      136      +72     
  Partials       39       39

oshin94 commented 2 years ago

@laszukdawid I have made the necessary changes as suggested. Please provide the approval so that we may see if it passes the workflow. Also, are you planning to merge the branch now or there are some more tests being planned to be implemented?

laszukdawid commented 2 years ago

If it passes (should) then it's a straight merge. This is an isolated feature and doesn't affect main functionality. I'll be happy to hear any feedback :)

oshin94 commented 2 years ago

If it passes (should) then it's a straight merge. This is an isolated feature and doesn't affect main functionality. I'll be happy to hear any feedback :)

Seems like an the build failed due to an error in the tests. Made necessary changes to fix that, it should hopefully pass this time.

laszukdawid commented 2 years ago

Thanks so much for adding this feature and for addressing all my requests! Much appreciate and I'm sure others will be as well :)

oshin94 commented 2 years ago

Thanks so much for adding this feature and for addressing all my requests! Much appreciate and I'm sure others will be as well :)

It was wonderful working with you as well. Learnt a lot in the process. Hope to contribute more in the upcoming days. BTW, your EMD implementation helped me a lot in my project work so this is a way to thank you for that as well.. :)