search

laszukdawid / PyEMD

Python implementation of Empirical Mode Decompoisition (EMD) method
https://pyemd.readthedocs.io/
Apache License 2.0
857 stars 222 forks source link

New splines #140

Closed JFadanni closed 1 year ago

JFadanni commented 1 year ago

In this branch I have introduced new splines for the fitting of the envelope. In particular, I have used the scipy.interpolate classes to replace the legacy interface for 1D-interpolation scipy.interpolate.interp1d in the already implemented splines and I have introduced the fitting with the Piecewise-cubic Hermite spline, class scipy.interpolate.CubicHermiteSpline, and the Piecewise Cubic Hermite Interpolating Polynomial, class scipy.interpolate.PchipInterpolator

laszukdawid commented 1 year ago

Hey @JFadanni,

Apologies for delay but I've been away. This PR looks good :) Thanks for your contribution, I'll merge it. It'd also be nice to have some tests added so if you have some extra time I'd appreciate these as well. Otherwise, maybe in some time I'll do them.

JFadanni commented 1 year ago

Thanks @laszukdawid,

I will try to add some tests for my part but I need a little more time