search

laszukdawid / ai-traineree

PyTorch agents and tools for (Deep) Reinforcement Learning
http://ai-traineree.readthedocs.io/
Apache License 2.0
24 stars 5 forks source link

Explicit use of observations and sizes (not spaces) #11

Closed laszukdawid closed 3 years ago

laszukdawid commented 3 years ago

Despite trying to be consistent there are inconsistencies and confusions about states/observations/features and their format.

These commits attempt try to make it clearer what is where. On top of actual naming changes there is doc update with developer's note.

States exist in the environment. Agent observes and create features based on these observations.

codecov[bot] commented 3 years ago

Codecov Report

Merging #11 (89d6f4b) into master (1ff42ea) will increase coverage by 0.12%. The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   75.35%   75.47%   +0.12%     
==========================================
  Files          35       35              
  Lines        4029     4074      +45     
==========================================
+ Hits         3036     3075      +39     
- Misses        993      999       +6
Impacted Files Coverage Δ
ai_traineree/networks/bodies.py 52.52% <55.26%> (-0.60%) :arrow_down:
ai_traineree/networks/heads.py 82.53% <75.00%> (-0.24%) :arrow_down:
ai_traineree/agents/d4pg.py 52.06% <78.57%> (+1.00%) :arrow_up:
ai_traineree/agents/td3.py 84.45% <89.28%> (+1.12%) :arrow_up:
ai_traineree/tasks.py 44.48% <91.66%> (+0.66%) :arrow_up:
ai_traineree/agents/dqn.py 77.91% <92.30%> (+0.13%) :arrow_up:
ai_traineree/agents/d3pg.py 82.97% <93.33%> (+0.37%) :arrow_up:
ai_traineree/agents/sac.py 74.77% <94.73%> (ø)
ai_traineree/__init__.py 68.75% <100.00%> (ø)
ai_traineree/agents/ddpg.py 81.81% <100.00%> (+0.64%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ff42ea...89d6f4b. Read the comment docs.