search

lat9 / ZCA-Bootstrap-Template

A Bootstrap-4 template for Zen Cart versions 1.5.8 through 2.1.0. Forked from https://github.com/zcadditions/ZCA-Bootstrap-Template-for-1.5.6-v2.0.0c. See the demo site, below, for additional information.
https://zc158.vinosdefrutastropicales.com/zc158/index.php?main_page=index
GNU General Public License v3.0
4 stars 14 forks source link

centerboxes\new_products.php comparison to core query #130

Closed torvista closed 1 year ago

torvista commented 2 years ago

Regarding these two lines in the BS file:

https://github.com/lat9/ZCA-Bootstrap-Template/blob/875f9ddf2d2c68879f68fa6254c5f4e55b0eb461/includes/modules/bootstrap/centerboxes/new_products.php#L69-L74

They are reversed to the core file (156/7/8): https://github.com/zencart/zencart/blob/90a0a1f4a44f0d08712b9ab8e597d7054b8c949c/includes/modules/new_products.php#L67-L69

So one of them is "wrong"....

lat9 commented 2 years ago

The ordering is actually inconsequential, since the two lines are dealing with separate elements. That said, the module is sorely in need of some refactoring and I'll put the order back to the core's version, albeit with PSR-12 formatting so that single-line if statement will be braced.