search

lat9 / ZCA-Bootstrap-Template

A Bootstrap-4 template for Zen Cart versions 1.5.8 through 2.1.0. Forked from https://github.com/zcadditions/ZCA-Bootstrap-Template-for-1.5.6-v2.0.0c. See the demo site, below, for additional information.
https://zc158.vinosdefrutastropicales.com/zc158/index.php?main_page=index
GNU General Public License v3.0
4 stars 14 forks source link

line-height settings for h tags #348

Closed dbltoe closed 7 months ago

dbltoe commented 7 months ago

I just loaded a test site of ZC 2.0 with the latest OPC, EO, and Bootstrap.

I haven't determined which one of the stylesheets is setting the line-height for h tags to 1.2 overriting with $line-height-base. Thus changing the 1.5 set in the body tag to 1.2. WCAG recommends 1.5 times basic font size for line height which is why 1.2 is triggering the the SiteImprove Accessibility Checker for a AAA error. axe Dev Tools does not show it but it is not always accurate on AAA requirements.

lat9 commented 7 months ago

You don't say what version of Bootstrap. I'm running v3.6.4 on zc200-rc2 and don't see such an override. Perhaps you could identify a page to check.

dbltoe commented 7 months ago

Running the same with a clone of basic 3.6.4.

And, dropping to non-cloned 3.6.4 cleared the problem. Apparently a bad clone.