search

lat9 / ZCA-Bootstrap-Template

A Bootstrap-4 template for Zen Cart versions 1.5.8 through 2.1.0. Forked from https://github.com/zcadditions/ZCA-Bootstrap-Template-for-1.5.6-v2.0.0c. See the demo site, below, for additional information.
https://zc158.vinosdefrutastropicales.com/zc158/index.php?main_page=index
GNU General Public License v3.0
4 stars 14 forks source link

shipping estimator: simple syntax?? #394

Closed torvista closed 4 months ago

torvista commented 5 months ago

https://github.com/lat9/ZCA-Bootstrap-Template/blob/b11499fe7bee2d58cd9244a63031a4401092c7ae/includes/templates/bootstrap/templates/tpl_modules_shipping_estimator.php#L85

I'm not understanding this construct:

${'postcode'}

which is not in current ZC.

And this is so different to the core version, it's quite a comparison headache.

torvista commented 5 months ago

Would it help if I updated this to match the core file as much as possible?

lat9 commented 5 months ago

Would it help if I updated this to match the core file as much as possible?

No.

lat9 commented 5 months ago

Yeah, the ${'postcode'} is the same as $postcode ... which is what I'll change it to.

My response above is that I find the PHP/HTML indentation in most of the core files to be indecipherable so I've got the PHP indented separately from the HTML. It helps (me, anyway) to ensure that the various HTML start/end tags line up as well as the PHP conditionals' curly-braces.