Closed retched closed 3 months ago
Running the shopping card through an evaluation tool suggested that to comply with WCAG standard 1.3.1 a <TH>
tag shouldn't be empty or contain images with no alt text.
So I hid the column that would contain the update button UNLESS it is explicitly set in the Admin dashboard. As well as change the last column, the total column, to a regular <TD>
instead of a <TH>
.
Thanks for this. I'll review later this weekend. Why the change to td
instead of th
?
It was a suggestion that
https://webaim.org/techniques/tables/data#th Table headers should never be empty. This is particularly of concern for the top-left cell of some tables
I'm not sure how stringent that is though.
One way we handle the "no empty header cell" elsewhere in Zen Cart is to simply give it a header of "Action". And often make that text aria-only.
I didn't even consider that as a possibility. I can make a similar change in another commit.
I reverted the empty cells to a <th>
but gave each column an aria-label header with an empty cell. I also added two language definitions to lang.zca_bootstrap_common.php
for this purpose.
Should be done. Also went ahead and adjusted the quantity field to render the HTML aligned within the <td>
itself too.
Also caught a spelling error with the define
name I used. Changed it to here as well.
Squashed the three commits to make things easier to follow.
Close enough. Please note that I'll be making a couple of slight formatting changes and adding the last-changed version to each module's lead-in comments.
Thanks for this!
Tie this PR to the associated issue, #410.
Hides the Update Cell in the Shopping Cart unless the option
SHOW_SHOPPING_CART_UPDATE
is specifically set toNext to each Qty Box
orBoth Next to each Qty Box and Below all Products
.