search

lat9 / ZCA-Bootstrap-Template

A Bootstrap-4 template for Zen Cart versions 1.5.8 through 2.1.0. Forked from https://github.com/zcadditions/ZCA-Bootstrap-Template-for-1.5.6-v2.0.0c. See the demo site, below, for additional information.
https://zc158.vinosdefrutastropicales.com/zc158/index.php?main_page=index
GNU General Public License v3.0
4 stars 14 forks source link

AJAX search doesn't search in a product's description #409

Closed lat9 closed 1 month ago

proseLA commented 2 months ago

for every person that wants to include search in description, there is another one that does not to include search in description. if we want to mimic what the base ZC does, i believe that offers a selection as to whether we want to search in a description or not.

in addition, adding (or subtracting) any field into the method zen_build_keyword_where_clause is very easily done using the notifier.

what does all of this mean? i'm just not sure this is a bug v intended behavior. searching in an ajax search and adding the description could really bog down the user experience as the ajax search gets executed for every keystroke (at least i think it does).

in any event, i think this should be configurable if you want to address this change.

lat9 commented 2 months ago

That's how the 'base' Zen Cart sidebox search works ... I thought (although I haven't used that for eons).

I'll revisit; sounds like it might be yet-another Bootstrap configuration setting.

proseLA commented 2 months ago

oh... interesting... good point. i was not thinking about the sidebox... i was thinking about the search results page...

even given that, i'm still of the opinion it should be configurable for the reason i mentioned above.

lat9 commented 2 months ago

I'm probably going to be naughty with this one, since I'm not a big fan of soft-configuration settings, and introduce that additional configuration setting (default, no descriptions included in search) for v3.7.2 rather than bumping to v3.8.0.