IDE inspection DbIoHandler.php, protected access queries

[torvista]

phpStorm is flagging this as a bug on queries

ADMIN\includes\classes\dbio\DbIoHandler.php

I'm not sure if it is.

[lat9]

I'm thinking that it's a false positive. The includes/classes/query_class.php has only public methods and no declarations of protected status on the queries array.

In addition, the DbIoHandler's queryCache and queryCacheOlder variables are created in the public __construct method, thus making them also public.

[torvista]

Ah, a minor but significant bit of information would be that this in is ZC158!!. Sorry!

class QueryCache
{
    protected $queries = [];

    /**
     * Cache SELECT statement query resources in application memory
     * returns TRUE if and only if query has been stored in cache
     * @param string $query query string, used as a key
     * @param mysqli_result $valueToStore result from mysqli_query
     * @return bool
     */

[lat9]

Still a phantom. The queries element of the QueryCache class is directly accessed only for the older (ca. zc151) version of the query_class.php class.

[torvista]

After forcing myself to understand this, you are of course, right.

[torvista]

From what I see, this "offending" bit of code is for an older query_class object that did not have the "reset" method: this was introduced in ZC153.