search

lat9 / dbio

Database Input/Output for Zen Cart
GNU General Public License v3.0
3 stars 1 forks source link

DBIoHandler using protected variable from query_cache #200

Closed torvista closed 7 months ago

torvista commented 1 year ago

IDE flags as a real error (as opposed to a warning):

https://github.com/lat9/dbio/blob/0579df4954f56ff5ba453b7ac9e42342b5674e0e/YOUR_ADMIN/includes/classes/dbio/DbIoHandler.php#L801

https://github.com/zencart/zencart/blob/6de01e2e6ce1b5d895743d9421bac6b52ae79957/includes/classes/query_cache.php#L16

I've not seen any error in real use.

lat9 commented 1 year ago

That's because that/those clauses aren't executed unless the associated class exists.