search

lat9 / edit_orders

Edit Orders: Updates for continued operation on Zen Cart v1.5.8 and later
GNU General Public License v2.0
5 stars 9 forks source link

add css buttons #151 #159

Closed proseLA closed 3 years ago

proseLA commented 3 years ago

hi cindy, i've finally decided to update my clients on this plugin. GREAT job on the math.... i think... i had some issues with the display on some tax rates, but my client uses something called OT_LOCAL_TAXES; i'll look at it further at some point. but the numbers added up perfectly and were correct! bravo!

as i talked about in february, i'm doing some updates to the look of this plugin. i'm not sure if you want them or not. you can let me know. i added a couple of methods. 1 was stolen directly from the latest orders script of v157. perhaps we can get them to put that into a class or function and not have to duplicate it here.

please let me know if you want this stuff. i'm trying to stick to the look in this branch.

best, pRose.

lat9 commented 3 years ago

Thanks for that. I'll hold it until such time as EO no longer supports the zc155 series (which doesn't support bootstrap).

proseLA commented 3 years ago

cindy, i think this will handle v155 and up...

you definitely want to review it. no logic change, i hope...

best.

proseLA commented 3 years ago

totally acceptable in psr-1 coding standard. and much cleaner looking, IMO.

https://www.php-fig.org/psr/psr-1/

but your repo.... :smirk: