lat9 / edit_orders

Edit Orders: Updates for continued operation on Zen Cart v1.5.8 and later
GNU General Public License v2.0
5 stars 9 forks source link

properly populate products_prid fixes #216 #217

Closed proseLA closed 10 months ago

proseLA commented 1 year ago

The reason I've stayed away from this is that the zen_get_uprid function uses a different algorithm (for whatever reason) on the admin vs. the storefront.

If you're OK with the fact that those uprid calculations are going to be different, I'm happy to accept these changes.

that may have been true at 1 time, and could explain a problem i was seeing.... but in a current v157 install, i can not reproduce the prid getting calculated differently. so i am good with that.

in addition, i think it is better than it is now.

image

lat9 commented 10 months ago

The code provided in this PR has now been merged into the forthcoming v4.7.0 branch; closing here.