search

lat9 / edit_orders

Edit Orders: Updates for continued operation on Zen Cart v1.5.8 and later
GNU General Public License v2.0
5 stars 9 forks source link

wiki and local sales taxes... #241

Open proseLA opened 1 month ago

proseLA commented 1 month ago

when i look at the wiki on local sales taxes, i am not sure why we need to have that element about copying the functions to the admin.

why don't you ask the last person maintaining that mod, ie @scottcwilson to add that file, aka:

YOUR_ADMIN/includes/functions/extra_functions/functions_local_sales_taxes.php

to the plugin. and rather than copying the file, have that file be something like:

if (!defined('IS_ADMIN_FLAG') || IS_ADMIN_FLAG !== true) {
        exit('Invalid access');
    }

    require DIR_FS_CATALOG . DIR_WS_FUNCTIONS . 'extra_functions/functions_local_sales_taxes.php';

i would do a PR on said plugin, but i do not see any public repo.

i will be looking at why edit orders can not seem to use a local sales tax as well. that seems pretty lame to me. if its an order total module, why should it not work here?

at some point we need to embrace the object in OOP.

lat9 commented 1 month ago

That is/was more a statement of interoperability, since the "Local Sales Tax" from eons ago wasn't a proper order-total and made a ton of ass-u-mptions about its operating environment (i.e. it presumed that it was only ever being run on the storefront).