search

lat9 / edit_orders

Edit Orders: Updates for continued operation on Zen Cart v1.5.8 and later
GNU General Public License v2.0
5 stars 9 forks source link

Use `zen_get_products_name` and account for empty model number in add-product dropdown. #243

Open proseLA opened 1 month ago

proseLA commented 1 month ago

i am not sure how long i have railed against stuff like this in various plugins:

https://github.com/lat9/edit_orders/blob/769b2cc91c9a8b562cc440b7f33522db47e74fdc/YOUR_ADMIN/includes/modules/edit_orders/eo_add_prdct_action_display.php#L109-L115

what is the purpose of having zen_get_products_name if we do not use it?

at some point, this PR will hopefully get merged, and we will now have something that better approaches a true product object.

does one really have to manually do all of this construction of what product name should be?

every time i see model included in some manually manipulated product name on anything to do with ZC, i truly feel people have just succumbed to whatever torvista wants.

some of my clients do not use product model, so every line item now has [] in it for no good reason.

can we at least embrace something that ZC provides us?

and please, i do not want to get into a discussion of database hits. with caching and websites being hosted on SSDs; these discussions are tiresome and so 2007....

lat9 commented 1 month ago

that "this PR" link doesn't go to where you intended.

proseLA commented 1 month ago

that "this PR" link doesn't go to where you intended.

100% correct.

since corrected.

meant to go here:

https://github.com/zencart/zencart/pull/6370