lat9 / gpsf

An update to the previous Numinix version, now supporting Zen Carts 1.5.6 and above (including 1.5.8a) as well as PHP versions 5.6 through 8.2.
GNU General Public License v2.0
2 stars 2 forks source link

problem with attribute key on options name #1

Closed proseLA closed 1 year ago

proseLA commented 1 year ago

https://github.com/lat9/gpsf/blob/3d645d4c7a457bcc6dab16e412e75d64ef28b2b4/includes/classes/gpsfFeedGenerator.php#L352

if the $key is empty, there will be a problem with the xml parsing.

i think the correction should be:

if (empty($key) || $value === false) {
lat9 commented 1 year ago

I'm not sure how to replicate this; are you saying that some sites would have option names that are an empty string?

proseLA commented 1 year ago

that's what is seems like to me. perhaps i screwed around with my data, and it's not something one would see "normally".

image

lat9 commented 1 year ago

Thanks for the update; will get that corrected in a bit.