search

lat9 / product_pagination

Zen Cart: Product Pagination
GNU General Public License v2.0
1 stars 1 forks source link

HTML Warning: <form> anchor "pp_count_form" already defined when "Include item-count drop-down" is true #14

Closed torvista closed 3 years ago

torvista commented 4 years ago

The form name is the same for the top and bottom links.

lat9 commented 4 years ago

Yes, this plugin needs a bit of "care & feeding"; thanks for the report.

torvista commented 4 years ago

I did some already in my branch, as a base spring clean, prior to fixing an issue I have with this.

torvista commented 4 years ago

similarly for pp_page_form

lat9 commented 4 years ago

I'm not seeing the additional form using the current repository file-set; @torvista could you recheck?

Note, too, that the changes for #20 and #15 could be problematic (for the styling). Please recheck.

torvista commented 4 years ago

If you are looking at my fork....I have no idea what was what and when....I think I wiped it all when revisiting this last week. I'll see when today's issues are resolved.

torvista commented 4 years ago

I doubt I resolved this....I guess some variable has to keep count of the calls to this module to put a unique suffix on the form name..or just add a timestamp to it!!

torvista commented 4 years ago

Sorry, I forgot about this duplicate form stuff... Clipboard02

lat9 commented 4 years ago

What page is this on?

torvista commented 4 years ago

Any that have the Items per page dropdown showing.

lat9 commented 4 years ago

Ah, the distinction is that the information is shown and there's neither a top nor bottom submit button rendered.

lat9 commented 4 years ago

There you go; suffixed the form-name based on the number of times that formatting block was called.

torvista commented 4 years ago

ok, note that pp_page_form needs the same.

lat9 commented 4 years ago

All better.