search

lat9 / product_pagination

Zen Cart: Product Pagination
GNU General Public License v2.0
1 stars 1 forks source link

Update for ZC200 #30

Closed torvista closed 6 months ago

torvista commented 9 months ago

That should do it.

lat9 commented 9 months ago

OMG, @torvista, that's going to take me a long time to review. Any chance of breaking this single PR into multiple ones with each addressing a single update?

torvista commented 9 months ago

That was the intention with the separate PRs to the branch. To be honest only the FIXES have real changes in them.

lat9 commented 8 months ago

The next version (v3.0.0) will start in the 3.0.0 branch. That will support zc158 and zc200 and the responsive_classic and Bootstrap templates.

For zc158, the changes present in this zc200 PR will be needed for the plugin's operation. That said, it's going to be a fairly major change, but I'll keep this PR open and make sure that the various changes provided are included!

torvista commented 8 months ago

That PR borked the shopfront. I've reverted the config.core for the moment.

lat9 commented 8 months ago

That PR borked the shopfront. I've reverted the config.core for the moment.

In what way? I'll note that it's not compatible with the current 'state' of the Products' Pagination plugin.

torvista commented 8 months ago

PHP Fatal error: Cannot declare class splitPageResults, because the name is already in use in \includes\classes\split_page_results.php on line 38 https://github.com/lat9/product_pagination/blob/74ac9248f0cb8982123dede839ffdbb6d2fbdad6/includes/classes/split_page_results.php#L38

lat9 commented 8 months ago

As I said above; I'd just added that note for this PR to indicate that I'll be using the changes you provided as a baseline, but v3.0.0 of Products' Pagination will be very different from previous versions.

torvista commented 8 months ago

Sure, no rush.

lat9 commented 6 months ago

Changes provided in this PR are now included in the v3.0.0 release; closing.