search

lat9 / upsxml

UPS-XML for Zen Cart
3 stars 4 forks source link

problem with negotiated rates... #34

Open proseLA opened 1 year ago

proseLA commented 1 year ago

i'm not a fan of these 2 lines of code:

https://github.com/lat9/upsxml/blob/c16570e87e9058e304678e2783409beca161126b/includes/modules/shipping/upsxml.php#L744 https://github.com/lat9/upsxml/blob/c16570e87e9058e304678e2783409beca161126b/includes/modules/shipping/upsxml.php#L752

i do not know why having this var $this->_upsDestStateProv be not blank is required to get one's negotiated rates.

the problem is how does one get their negotiated rates? if we look at this key MODULE_SHIPPING_UPSXML_RATES_CUSTOMER_CLASSIFICATION_CODE, i would have thought that this would provide a customers negotiated rates; but alas it does not. it is something completely different.

so there is really no key in this module to indicate what sort of pricing one wants to provide to the customer, ie i get some really good discounts, and i would like to give that back to my customer. and there really should be.

proseLA commented 1 year ago

actually in thinking about it, no new key is necessary. if someone puts in their shipper number then they want the negotiated rates. that makes sense.