search

latchset / custodia

An API to manage secrets storage and retrieval
GNU General Public License v3.0
85 stars 27 forks source link

Add connection timeout to Custodia client #211

Closed tiran closed 7 years ago

tiran commented 7 years ago

Custodia client classes have grown a default timeout instance attribute. The forwarder plugin and CLI have a new timeout option. The default timeout for both is 10 seconds.

Signed-off-by: Christian Heimes cheimes@redhat.com Closes: #208

codecov-io commented 7 years ago

Codecov Report

Merging #211 into master will decrease coverage by 1.06%. The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   69.94%   68.87%   -1.07%     
==========================================
  Files          31       32       +1     
  Lines        3234     3422     +188     
  Branches      352      380      +28     
==========================================
+ Hits         2262     2357      +95     
- Misses        851      944      +93     
  Partials      121      121
Impacted Files Coverage Δ
tests/test_cli.py 82.66% <100%> (+2.66%) :arrow_up:
tests/test_custodia.py 95.01% <100%> (+0.01%) :arrow_up:
src/custodia/client.py 79.8% <100%> (+0.2%) :arrow_up:
src/custodia/cli/__init__.py 45.71% <91.66%> (ø)
src/custodia/log.py 78.7% <0%> (+1.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 63821d3...d075e06. Read the comment docs.