search

latchset / custodia

An API to manage secrets storage and retrieval
GNU General Public License v3.0
85 stars 27 forks source link

Misc SSL related fixes #220

Closed tiran closed 7 years ago

tiran commented 7 years ago

Add temporary workaround for issue with latest urllib3

The problem is addressed in requests dev:

See https://github.com/requests/requests/blob/master/HISTORY.rst

Fixed issue where Requests would raise ConnectionError instead of SSLError when encoutering SSL problems when using urllib3 v1.22.

Add client auth EKU to CA

OpenSSL 1.1.0 is more strict and validates EKU of CA. Our test CA has only EKU "TLS Web Server Authentication" set. Add "TLS Web Client Authentication" to fix tests on Fedora 26.

codecov-io commented 7 years ago

Codecov Report

Merging #220 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   69.94%   69.94%           
=======================================
  Files          31       31           
  Lines        3234     3234           
  Branches      352      352           
=======================================
  Hits         2262     2262           
  Misses        851      851           
  Partials      121      121
Impacted Files Coverage Δ
tests/test_custodia.py 95% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df62abb...c9baeba. Read the comment docs.