search

latchset / custodia

An API to manage secrets storage and retrieval
GNU General Public License v3.0
85 stars 27 forks source link

Add support for GSSAPI authentication. #235

Closed adelton closed 6 years ago

simo5 commented 6 years ago

can you add proper deps on request_gssapi and a test ?

adelton commented 6 years ago

Would you prefer deps, or maybe weakening the import and failing in runtime if the modules is not available?

As for tests, I'm not really sure how we would test it, given we'd likely need KDC for that ...

frozencemetery commented 6 years ago

Thanks for using requests_gssapi! If tests are needed, it may be possible to use k5test.

That said, I'm not sure there's a lot of value in setting up a full test with KDC here, since bugs in that would be bugs in a lower component - perhaps it'd be better to check that it starts a GSSAPI handshake when prompted?

tiran commented 6 years ago

I don't think we need a full integration test or functional test here. A unit test is good enough, just check that the function sets the object.

raildo commented 6 years ago

Can you also rebase that patch? So, it would be also in a good shape passing the tests.

adelton commented 6 years ago

Closing in favour of https://github.com/latchset/custodia/pull/238.