test_client_no_client_cert fails

stanislavlevin commented 5 years ago

I'm running the test suite.

===================================== test session starts =====================================
platform linux -- Python 3.7.2, pytest-4.3.1, py-1.8.0, pluggy-0.9.0
cachedir: .tox/py37-extras/.pytest_cache
rootdir: /home/test/custodia/custodia, inifile: tox.ini
collected 162 items                                                                           

tests/test_authenticators.py ..
tests/test_cli.py .....
tests/test_custodia.py ..........................................F.
tests/test_httpd.py .
tests/test_ipa.py ........................
tests/test_message_kem.py ....
tests/test_misc.py ...
tests/test_plugins.py ....
tests/test_secrets.py ..................................
tests/test_server.py ....
tests/test_store.py ...
tests/test_store_sqlite.py ...........
tests/functional/test_basics.py ...
tests/functional/test_container.py .........
tests/functional/test_key.py ...........

========================================== FAILURES ===========================================
________________________ CustodiaHTTPSTests.test_client_no_client_cert ________________________

self = <test_custodia.CustodiaHTTPSTests testMethod=test_client_no_client_cert>

    def test_client_no_client_cert(self):
        client = CustodiaSimpleClient(self.socket_url + '/forwarder')
        client.headers['REMOTE_USER'] = 'test'
        client.set_ca_cert(self.ca_cert)
        # XXX workaround for requests bug with urllib3 v1.22
        with self.assertRaises(RequestsConnSSLErrors) as e:
            client.list_container('test')
        self.assert_ssl_error_msg("SSLV3_ALERT_HANDSHAKE_FAILURE",
>                                 e.exception)

tests/test_custodia.py:520: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/test_custodia.py:502: in assert_ssl_error_msg
    self.fail(str(exc))
E   AssertionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

It seems that urllib3 doesn't support TLS1.3 yet: https://github.com/urllib3/urllib3/pull/1496

simo5 commented 5 years ago

What platform are you running this on ?

stanislavlevin commented 5 years ago

Fedora29

simo5 commented 5 years ago

@tiran how do we fix this ?

latchset / custodia

test_client_no_client_cert fails #245