Closed kloczek closed 9 months ago
sarroutbi
commented
2 years ago Hello @kloczek.
I am not able to reproduce this. Can you please give more information on the environment you are using?
kloczek
commented
2 years ago Hello @kloczek.
I am not able to reproduce this. Can you please give more information on the environment you are using?
- operating system
Linux x86/84,, krenerl 5.17.11
- cpu architecture, cpu number
[tkloczko@devel-g2v SPECS]$ lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 46 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 48 On-line CPU(s) list: 0-47 Vendor ID: GenuineIntel Model name: Intel(R) Xeon(R) Silver 4116 CPU @ 2.10GHz CPU family: 6 Model: 85 Thread(s) per core: 2 Core(s) per socket: 12 Socket(s): 2 Stepping: 4 CPU(s) scaling MHz: 28% CPU max MHz: 3000.0000 CPU min MHz: 800.0000 BogoMIPS: 4200.00 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp l m constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 s sse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpui d_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust b mi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke m d_clear flush_l1d arch_capabilities Virtualization features: Virtualization: VT-x Caches (sum of all): L1d: 768 KiB (24 instances) L1i: 768 KiB (24 instances) L2: 24 MiB (24 instances) L3: 33 MiB (2 instances) NUMA: NUMA node(s): 2 NUMA node0 CPU(s): 0-11,24-35 NUMA node1 CPU(s): 12-23,36-47 Vulnerabilities: Itlb multihit: KVM: Mitigation: VMX disabled L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable Mds: Mitigation; Clear CPU buffers; SMT vulnerable Meltdown: Mitigation; PTI Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Spectre v2: Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP conditional, RSB filling Srbds: Not affected Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable- RAM memory
128 GB, no swap
- any other stuff that could be helpful
I'm runnimg all my builds insize LXC zones. I'm not sure what more may be relevant in this context. I'm opened on any suggestions 😄
sarroutbi
commented
1 year ago Hello. Sorry I missed your latest message.
Can you please paste the output of the log file?. /home/tkloczko/rpmbuild/BUILD/jose-11/x86_64-redhat-linux-gnu/meson-logs/testlog.txt
I tested again and I was not able to reproduce it
Barbaross93
commented
1 year ago I think I'm running into a similar problem trying to build jose with Void Linux's xbps-src. Here's the output from trying to run ./xbps-src -f pkg jose:
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://repo-default.voidlinux.org/current/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> jose-11_1: removing autodeps, please wait...
=> jose-11_1: building [meson] for x86_64...
[host] git-2.40.0_1: found (https://repo-default.voidlinux.org/current)
[host] asciidoc-9.1.1_1: found (https://repo-default.voidlinux.org/current)
[host] pkg-config-0.29.2_3: found (https://repo-default.voidlinux.org/current)
[host] meson-1.0.1_1: found (https://repo-default.voidlinux.org/current)
[target] zlib-devel-1.2.13_1: found (https://repo-default.voidlinux.org/current)
[target] jansson-devel-2.14_1: found (https://repo-default.voidlinux.org/current)
[target] openssl-devel-1.1.1t_1: found (https://repo-default.voidlinux.org/current)
[runtime] jansson-2.14_1: found (https://repo-default.voidlinux.org/current)
[runtime] openssl-1.1.1t_1: found (https://repo-default.voidlinux.org/current)
[runtime] zlib-1.2.13_1: found (https://repo-default.voidlinux.org/current)
=> jose-11_1: installing host dependencies: git-2.40.0_1 asciidoc-9.1.1_1 pkg-config-0.29.2_3 meson-1.0.1_1 ...
=> jose-11_1: installing target dependencies: zlib-devel-1.2.13_1 jansson-devel-2.14_1 openssl-devel-1.1.1t_1 ...
=> jose-11_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> jose-11_1: running pre-configure hook: 01-override-config ...
=> jose-11_1: running pre-configure hook: 02-script-wrapper ...
=> jose-11_1: running do_configure ...
The Meson build system
Version: 1.0.1
Source dir: /builddir/jose-11
Build dir: /builddir/jose-11/build
Build type: native build
Project name: jose
Project version: 11
C compiler for the host machine: cc (gcc 12.2.0 "cc (GCC) 12.2.0")
C linker for the host machine: cc ld.bfd 2.39
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Run-time dependency zlib found: YES 1.2.13
Run-time dependency threads found: YES
Run-time dependency jansson found: YES 2.14
Run-time dependency libcrypto found: YES 1.1.1t
Program a2x found: YES (/usr/bin/a2x)
Configuring jose.h using configuration
Checking if "-Wl,--version-script=..." : links: YES
Program ./jose-alg found: YES (/builddir/jose-11/tests/./jose-alg)
Program ./jose-fmt found: YES (/builddir/jose-11/tests/./jose-fmt)
Program ./jose-b64-enc found: YES (/builddir/jose-11/tests/./jose-b64-enc)
Program ./jose-b64-dec found: YES (/builddir/jose-11/tests/./jose-b64-dec)
Program ./jose-jwk-eql found: YES (/builddir/jose-11/tests/./jose-jwk-eql)
Program ./jose-jwk-exc found: YES (/builddir/jose-11/tests/./jose-jwk-exc)
Program ./jose-jwk-gen found: YES (/builddir/jose-11/tests/./jose-jwk-gen)
Program ./jose-jwk-pub found: YES (/builddir/jose-11/tests/./jose-jwk-pub)
Program ./jose-jwk-use found: YES (/builddir/jose-11/tests/./jose-jwk-use)
Program ./jose-jwk-thp found: YES (/builddir/jose-11/tests/./jose-jwk-thp)
Program ./jose-jws-fmt found: YES (/builddir/jose-11/tests/./jose-jws-fmt)
Program ./jose-jws-ver found: YES (/builddir/jose-11/tests/./jose-jws-ver)
Program ./jose-jws-sig found: YES (/builddir/jose-11/tests/./jose-jws-sig)
Program ./jose-jwe-fmt found: YES (/builddir/jose-11/tests/./jose-jwe-fmt)
Program ./jose-jwe-dec found: YES (/builddir/jose-11/tests/./jose-jwe-dec)
Program ./jose-jwe-enc found: YES (/builddir/jose-11/tests/./jose-jwe-enc)
Run-time dependency openssl found: YES 1.1.1t
Build targets in project: 28
jose 11
User defined options
auto_features : auto
bindir : /usr/bin
buildtype : plain
datadir : /usr/share
includedir : /usr/include
infodir : /usr/share/info
libdir : /usr/lib64
libexecdir : /usr/libexec
localedir : /usr/share/locale
localstatedir : /var
mandir : /usr/share/man
prefix : /usr
sbindir : /usr/bin
sharedstatedir: /var/lib
sysconfdir : /etc
wrap_mode : nodownload
b_lto : true
b_ndebug : true
b_staticpic : true
Found ninja-1.11.1 at /usr/bin/ninja
=> jose-11_1: running pre-build hook: 02-script-wrapper ...
=> jose-11_1: running do_build ...
ninja: Entering directory `build'
[1/86] Compiling C object lib/libjose.so.0.0.0.p/misc.c.o
[2/86] Compiling C object lib/libjose.so.0.0.0.p/hooks.c.o
[3/86] Compiling C object lib/libjose.so.0.0.0.p/hsh.c.o
[4/86] Compiling C object lib/libjose.so.0.0.0.p/cfg.c.o
[5/86] Compiling C object lib/libjose.so.0.0.0.p/io.c.o
[6/86] Compiling C object lib/libjose.so.0.0.0.p/b64.c.o
[7/86] Compiling C object lib/libjose.so.0.0.0.p/jws.c.o
[8/86] Compiling C object lib/libjose.so.0.0.0.p/jwk.c.o
[9/86] Compiling C object lib/libjose.so.0.0.0.p/zlib_deflate.c.o
[10/86] Compiling C object lib/libjose.so.0.0.0.p/jwe.c.o
[11/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_compat.c.o
[12/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_aesgcmkw.c.o
[13/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_dir.c.o
[14/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_aeskw.c.o
[15/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_aesgcm.c.o
[16/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_aescbch.c.o
[17/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_ec.c.o
[18/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_lock.c.o
[19/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_ecdh.c.o
[20/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_ecmr.c.o
[21/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_hash.c.o
[22/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_ecdsa.c.o
[23/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_ecdhes.c.o
[24/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_hmac.c.o
[25/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_jwk.c.o
[26/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_oct.c.o
[27/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_misc.c.o
[28/86] Compiling C object cmd/jose.p/b64_dec.c.o
[29/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_rsa.c.o
[30/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_pbes2.c.o
[31/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_rsassa.c.o
[32/86] Compiling C object lib/libjose.so.0.0.0.p/openssl_rsaes.c.o
[33/86] Compiling C object cmd/jose.p/jose.c.o
[34/86] Compiling C object cmd/jose.p/b64_enc.c.o
[35/86] Compiling C object cmd/jose.p/jwk_eql.c.o
[36/86] Compiling C object cmd/jose.p/jwk_exc.c.o
[37/86] Compiling C object cmd/jose.p/jwk_gen.c.o
[38/86] Compiling C object cmd/jose.p/jwk_pub.c.o
[39/86] Compiling C object cmd/jose.p/jwk_thp.c.o
[40/86] Compiling C object cmd/jose.p/jwk_use.c.o
[41/86] Compiling C object cmd/jose.p/jws_fmt.c.o
[42/86] Compiling C object cmd/jose.p/jws_sig.c.o
[43/86] Compiling C object cmd/jose.p/jwe_fmt.c.o
[44/86] Compiling C object cmd/jose.p/jws_ver.c.o
[45/86] Compiling C object cmd/jose.p/jwe_dec.c.o
[46/86] Compiling C object cmd/jose.p/alg.c.o
[47/86] Compiling C object tests/alg_hash.p/alg_hash.c.o
[48/86] Compiling C object tests/alg_encr.p/alg_encr.c.o
FAILED: tests/alg_encr.p/alg_encr.c.o
cc -Itests/alg_encr.p -Itests -I../tests -I/builddir/jose-11 -I/builddir/jose-11/build -flto=auto -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=gnu99 -Wstrict-aliasing -Wchar-subscripts -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wsign-compare -Wstrict-prototypes -Wtype-limits -Wunused-function -Wno-missing-field-initializers -Wno-unused-command-line-argument -Wno-unused-parameter -Wno-unknown-pragmas -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/jose-11/build=. -MD -MQ tests/alg_encr.p/alg_encr.c.o -MF tests/alg_encr.p/alg_encr.c.o.d -o tests/alg_encr.p/alg_encr.c.o -c ../tests/alg_encr.c
../tests/alg_encr.c: In function 'test':
../tests/alg_encr.c:67:18: error: unused variable 'xxx' [-Werror=unused-variable]
67 | uint8_t *xxx = ebuf;
| ^~~
At top level:
cc1: note: unrecognized command-line option '-Wno-unused-command-line-argument' may have been intended to silence earlier diagnostics
cc1: all warnings being treated as errors
[49/86] Compiling C object tests/alg_sign.p/alg_sign.c.o
[50/86] Compiling C object tests/alg_wrap.p/alg_wrap.c.o
[51/86] Compiling C object cmd/jose.p/jwe_enc.c.o
[52/86] Compiling C object cmd/jose.p/fmt.c.o
[53/86] Compiling C object tests/alg_comp.p/alg_comp.c.o
[54/86] Compiling C object tests/api_b64.p/api_b64.c.o
FAILED: tests/api_b64.p/api_b64.c.o
cc -Itests/api_b64.p -Itests -I../tests -I/builddir/jose-11 -I/builddir/jose-11/build -flto=auto -fdiagnostics-color=always -DNDEBUG -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=gnu99 -Wstrict-aliasing -Wchar-subscripts -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow -Wsign-compare -Wstrict-prototypes -Wtype-limits -Wunused-function -Wno-missing-field-initializers -Wno-unused-command-line-argument -Wno-unused-parameter -Wno-unknown-pragmas -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe -ffile-prefix-map=/builddir/jose-11/build=. -MD -MQ tests/api_b64.p/api_b64.c.o -MF tests/api_b64.p/api_b64.c.o.d -o tests/api_b64.p/api_b64.c.o -c ../tests/api_b64.c
../tests/api_b64.c: In function 'main':
../tests/api_b64.c:64:17: error: unused variable 'dec' [-Werror=unused-variable]
64 | uint8_t dec[3] = {};
| ^~~
../tests/api_b64.c:63:24: error: unused variable 'enc' [-Werror=unused-variable]
63 | union encoding enc = { i };
| ^~~
../tests/api_b64.c:75:17: error: unused variable 'dec' [-Werror=unused-variable]
75 | uint8_t dec[3] = { i };
| ^~~
../tests/api_b64.c:107:21: error: unused variable 'dec' [-Werror=unused-variable]
107 | uint8_t dec[3] = { i, j };
| ^~~
At top level:
cc1: note: unrecognized command-line option '-Wno-unused-command-line-argument' may have been intended to silence earlier diagnostics
cc1: all warnings being treated as errors
[55/86] Linking target lib/libjose.so.0.0.0
ninja: build stopped: subcommand failed.
=> ERROR: jose-11_1: do_build: '${make_cmd} -C ${meson_builddir} ${makejobs} ${make_build_args} ${make_build_target}' exited with 1
=> ERROR: in do_build() at common/build-style/meson.sh:133The template file I've written so far to build jose is:
# Template file for 'jose'
pkgname=jose
version=11
revision=1
#archs="i686 x86_64"
#build_wrksrc=
build_style=meson
#configure_args=""
#make_build_args=""
#make_install_args=""
#conf_files=""
#make_dirs="/var/log/dir 0755 root root"
hostmakedepends="git asciidoc pkg-config"
makedepends="zlib-devel jansson-devel openssl-devel"
depends="jansson openssl zlib"
short_desc="C-language implementation of Javascript Object Signing and Encryption"
maintainer="Barbaross <cullen.ross@proton.me>"
license="Apache"
homepage="https://github.com/latchset/jose"
#changelog=""
distfiles="https://github.com/latchset/jose/archive/refs/tags/v${version}.tar.gz"
checksum=020b28ba22f8448bd8eb659dad5723d59bea4d27a36731e33c102ca2a4fe5822I sincerely doubt about the enc/dec errors, as the variable is used (a sizeof is calculated on it). I will upload a fix for xxx. If you could test it, it would be great.
sarroutbi
commented
1 year ago @kloczek : Can you please try applying proposed patch (#127) to check if issue is fixed?
kloczek
commented
1 year ago OK. One sec 😋
kloczek
commented
1 year ago Cannot apply that on top of last release
warning: Downloading https://github.com/mpdavis/python-jose//archive/3.3.0/python-jose-3.3.0.tar.gz to /home/tkloczko/rpmbuild/SOURCES/python-jose-3.3.0.tar.gz
warning: Downloading https://github.com/latchset/jose/pull/127.patch#/python-jose-Fix-test-compilation-warnings.patch to /home/tkloczko/rpmbuild/SOURCES/python-jose-Fix-test-compilation-warnings.patch
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.K7RhSv
+ umask 022
+ cd /home/tkloczko/rpmbuild/BUILD
+ cd /home/tkloczko/rpmbuild/BUILD
+ rm -rf python-jose-3.3.0
+ /usr/bin/gzip -dc /home/tkloczko/rpmbuild/SOURCES/python-jose-3.3.0.tar.gz
+ /usr/bin/tar -xof -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd python-jose-3.3.0
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ /usr/bin/cat /home/tkloczko/rpmbuild/SOURCES/python-jose-Fix-test-compilation-warnings.patch
+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f
The text leading up to this was:
--------------------------
|From 42471994091b82a2990e1e8e6efd731f90b69469 Mon Sep 17 00:00:00 2001
|From: Sergio Arroutbi <sarroutb@redhat.com>
|Date: Fri, 24 Mar 2023 15:17:29 +0100
|Subject: [PATCH] Fix test compilation warnings
|
|Resolves: #116
|
|Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
|---
| tests/alg_encr.c | 9 ++++++---
| tests/api_b64.c | 3 +++
| 2 files changed, 9 insertions(+), 3 deletions(-)
|
|diff --git a/tests/alg_encr.c b/tests/alg_encr.c
|index 5adf189..d69d721 100644
|--- a/tests/alg_encr.c
|+++ b/tests/alg_encr.c
--------------------------
No file to patch. Skipping patch.
1 out of 1 hunk ignored
The text leading up to this was:
--------------------------
|diff --git a/tests/api_b64.c b/tests/api_b64.c
|index 027e7bf..2e44739 100644
|--- a/tests/api_b64.c
|+++ b/tests/api_b64.c
--------------------------
No file to patch. Skipping patch.
3 out of 3 hunks ignoredThx. It seems you are not applying the patch to the correct tree ... are you applying it to jose or python-jose?
kloczek
commented
9 months ago Thank you 👍 😄
BTW: is it possible to add below patch:
--- a/meson.build
+++ b/meson.build
@@ -42,16 +42,12 @@
mans = []
-licenses = ['COPYING']
-
subdir('include')
subdir('doc')
subdir('lib')
subdir('cmd')
subdir('tests')
-install_data(licenses, install_dir: licensedir)
-
pkg = import('pkgconfig')
pkg.generate(
description: 'Library for managing JOSE objects',COPYING file is not essential ..
sarroutbi
commented
9 months ago Just tested and all looks good now
+ cd jose-11 + /usr/bin/meson test -C x86_64-redhat-linux-gnu --num-processes 48 --print-errorlogs ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/jose-11/x86_64-redhat-linux-gnu' ninja: no work to do. 1/25 alg_hash OK 0.15s 2/25 alg_comp OK 0.13s 3/25 api_jwe OK 0.11s 4/25 alg_encr OK 0.14s 5/25 api_jws OK 0.12s 6/25 jose-b64-enc OK 0.10s 7/25 jose-b64-dec OK 0.10s 8/25 jose-jwk-pub OK 0.08s 9/25 issue75 OK 0.02s 10/25 jose-alg OK 0.12s 11/25 jose-jwk-thp OK 0.07s 12/25 jose-jwk-eql OK 0.14s 13/25 jose-jwk-use OK 0.18s 14/25 jose-jws-ver OK 0.30s 15/25 jose-jwk-exc OK 0.34s 16/25 jose-jws-fmt OK 0.35s 17/25 jose-jwe-dec OK 0.37s 18/25 jose-jwe-fmt OK 0.40s 19/25 alg_sign OK 0.55s 20/25 alg_wrap OK 0.64s 21/25 jose-fmt OK 0.67s 22/25 jose-jwk-gen OK 1.16s 23/25 api_b64 OK 2.24s 24/25 jose-jwe-enc OK 5.39s 25/25 jose-jws-sig OK 5.60s Ok: 25 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 0 Timeout: 0Thank you 👍 😄
BTW: is it possible to add below patch:
--- a/meson.build +++ b/meson.build @@ -42,16 +42,12 @@ mans = [] -licenses = ['COPYING'] - subdir('include') subdir('doc') subdir('lib') subdir('cmd') subdir('tests') -install_data(licenses, install_dir: licensedir) - pkg = import('pkgconfig') pkg.generate( description: 'Library for managing JOSE objects',COPYING file is not essential ..
Hello @kloczek. Thanks for your suggestion. Can you please open an issue for it? This way we can keep track of this change separately
kloczek
commented
9 months ago I'll open PR 😋
Looks like one assertion is failing. However in error message there sis no any hints why.