search

latchset / jwcrypto

Implements JWK,JWS,JWE specifications using python-cryptography
GNU Lesser General Public License v3.0
439 stars 118 forks source link

Fix typo in new backwards JWT compat heuristics #303

Closed jcgruenhage closed 2 years ago

jcgruenhage commented 2 years ago

I just noticed that the test suite of a package I'm working on are suddenly failing. Short digging later, there was a typo in the newly released 1.4.1

simo5 commented 2 years ago

Argh, and of course this is one of the heuristics I forogt to add a test for ...

simo5 commented 2 years ago

Would you mind adding a test in the tests file which checks this condition? If not I can do it.

I will release 1.4.2 right after we get this in, sigh.

simo5 commented 2 years ago

NVM, I could not resist and pushed a commit on your branch, so I can deal with this quickly

simo5 commented 2 years ago

Thanks for spotting this, very appreciated

jcgruenhage commented 2 years ago

No, no, thank you for working on this, promptly writing a test case and getting this merged and released in absolutely no time. I merely spotted the issue ;)