search

latchset / jwcrypto

Implements JWK,JWS,JWE specifications using python-cryptography
GNU Lesser General Public License v3.0
439 stars 118 forks source link

Dependency to typing_extensions broken #341

Closed bernhardboehmer closed 9 months ago

bernhardboehmer commented 9 months ago

The dependecy to typing_extension does not require a certain version (range). However, an error occurs due to a missing module of typing_extension: File "/usr/local/lib/python3.10/site-packages/jwcrypto/jwk.py", line 14, in from typing_extensions import deprecated ImportError: cannot import name 'deprecated' from 'typing_extensions' (/usr/local/lib/python3.10/site-packages/typing_extensions.py)

Please add a defined version (range) to your dependencies.

Nekodann commented 9 months ago

Can confirm same issue this morning

bernhardboehmer commented 9 months ago

We have a hard-set version of 4.4.0 for typing ext. Upgrading to 4.9.0 seems to make it. This means that setup.cfg should limit the lowest version of typing_extensions.

simo5 commented 9 months ago

so we need >= 4.9.0 ? I feel 1.5.4 coming :-D

simo5 commented 9 months ago

@bernhardboehmer can you confirm which version needs to be claimed as minima?

yan12125 commented 9 months ago

Per https://typing-extensions.readthedocs.io/en/latest/#deprecated, deprecated is added to typing_extensions in 4.5.0

simo5 commented 9 months ago

Ok released a fixed version: https://github.com/latchset/jwcrypto/releases/tag/v1.5.4