search

latchset / kryoptic

a pkcs#11 software token written in Rust
GNU General Public License v3.0
10 stars 4 forks source link

Add AES Key Wrap support #50

Closed simo5 closed 4 months ago

simo5 commented 4 months ago

Includes applicable test vectors from CMVP

Resolves #13

Jakuje commented 4 months ago

Resolves #13?

simo5 commented 4 months ago

code wise looks good, but it looks like the commit codespell does not like the main.. revision even though I believe it should be correctly pulled at that time. I tried to fix it, but without success. Any idea what could be wrong?

In PRs there is no checked out main branch I think, so you would have to reference it as origin/main ?

simo5 commented 4 months ago

Thanks for the review, merging.

Jakuje commented 4 months ago

code wise looks good, but it looks like the commit codespell does not like the main.. revision even though I believe it should be correctly pulled at that time. I tried to fix it, but without success. Any idea what could be wrong?

In PRs there is no checked out main branch I think, so you would have to reference it as origin/main ?

It should be there:

https://github.com/latchset/kryoptic/blob/main/.github/workflows/check-style.yml#L36