latebit / latebit-engine

Pixel based game engine integrated in your IDE
3 stars 0 forks source link

[sid]: Unhandled out of bound error when tracks have length zero #57

Closed shikaan closed 5 months ago

shikaan commented 5 months ago

https://github.com/latebit/latebit-engine/blob/f6fc86236e77853b67d80961a85c5b0ea6c073e8/latebit/sid/synth/sequencer.cpp#L128

This method does not account for the case where a track exists by it's empty (it always assumed that if there is a track, then it has at least an item).

The at-> calls are throwing an exception.

Expected Behaviour Empty tracks should be handled gracefully (i.e., ignored by the sequencer)

shikaan commented 5 months ago

Closed by https://github.com/latebit/latebit-engine/pull/63