Avoid hang in raspberry firmware driver

lategoodbye / rpi-zero

Linux kernel source tree

Other

22 stars 3 forks source link

Avoid hang in raspberry firmware driver #39

Closed lategoodbye closed 5 years ago

lategoodbye commented 6 years ago

rpi_firmware_transaction() doesn't use a timeout for its completion, which could result in endless block for the caller. We could fix this by defining a timeout of at least 1 second and return -ETIMEDOUT in case of no response. We also should do a big fat warn if this happens.

https://github.com/raspberrypi/firmware/issues/999

lategoodbye commented 5 years ago

Here the current attempt: https://github.com/lategoodbye/rpi-zero/commit/066524ed3ed8fccc4cbc5df720de967a8b60820a

lategoodbye commented 5 years ago

The patch has been send: https://lore.kernel.org/patchwork/patch/1004603/