latenighttales / alcali

Featureful Saltstack GUI
https://alcali.dev
MIT License
356 stars 61 forks source link

#295 Makes alcali uninstallable on CentOS 8 #305

Closed ggiesen closed 3 years ago

ggiesen commented 3 years ago

Describe the bug The new requirement in #295 make Alcali uninstallable on CentOS 8 due to the requirement for djangorestframework-simplejwt==4.6.0 (up from 4.4.0). The jump from 4.40 to 4.50 removed support for Python 3.6, which is the python version in CentOS 8/RHEL 8/OL 8

To Reproduce Steps to reproduce the behavior:

  1. Configure alcali formula & pillar data
  2. salt host state.apply
    ----------
          ID: alcali-package-install-virtualenv-managed
    Function: virtualenv.managed
        Name: /opt/alcali/.venv
      Result: False
     Comment: virtualenv exists
              Collecting ansi2html==1.6.0
                Using cached ansi2html-1.6.0-py3-none-any.whl (14 kB)
              Collecting Django==3.1.4
                Using cached Django-3.1.4-py3-none-any.whl (7.8 MB)
              Collecting django-cors-headers==3.6.0
                Using cached django_cors_headers-3.6.0-py3-none-any.whl (12 kB)
              Collecting django-currentuser==0.5.2
                Using cached django_currentuser-0.5.2-py2.py3-none-any.whl (6.7 kB)
              Collecting djangorestframework==3.12.1
                Using cached djangorestframework-3.12.1-py3-none-any.whl (913 kB)
              ERROR: Could not find a version that satisfies the requirement djangorestframework-simplejwt==4.6.0
              ERROR: No matching distribution found for djangorestframework-simplejwt==4.6.0
     Started: 23:20:53.171240
    Duration: 2434.457 ms
     Changes:   
    ----------
          ID: alcali-package-install-pip-installed
    Function: pip.installed
        Name: psycopg2
      Result: False
     Comment: One or more requisite failed: alcali.package.install.alcali-package-install-virtualenv-managed
     Started: 23:20:55.606930
    Duration: 0.004 ms
     Changes:   

Expected behavior Install alcali

Additional context Was it your intention to remove support for running alcali on CentOS 8? Is djangorestframework-simplejwt 4.6.0 actually required or was it bumped out of convenience?

mattLLVW commented 3 years ago

It was bumped to fix this related to this issue. I'll revert the update for now.

mattLLVW commented 3 years ago

new version published.