latenighttales / alcali

Featureful Saltstack GUI
https://alcali.dev
MIT License
356 stars 61 forks source link

fix(requirements): django simplejwt can't be installed #386

Closed baby-gnu closed 2 years ago

baby-gnu commented 3 years ago

We can't install Alcali with the current requirements:

ERROR: Could not find a version that satisfies the requirement
djangorestframework-simplejwt==4.4.0

When relaxing the version, it install 4.6.0.

drscream commented 3 years ago

:+1:

mattLLVW commented 3 years ago

Hi @baby-gnu and thanks for the PR. Unfortunately we already tried to update it, see #305 , but it seems that djangorestframework-simplejwt version 4.6.0 drop support for Python 3.6... So what's your Python version?

baby-gnu commented 3 years ago

Hi @baby-gnu and thanks for the PR. Unfortunately we already tried to update it, see #305 , but it seems that djangorestframework-simplejwt version 4.6.0 drop support for Python 3.6... So what's your Python version?

Hello @mattLLVW, I'm using python 3.9.2 from Debian stable.

It looked like most distributions have a recent enough python3 except for Ubuntu Bionic, CentOS 7 and openSUSE Leap 15.

But maybe CentOS 8 has python 3.6 by default.

Another option is to remove the version spec for djangorestframework-simplejwt and let pip find the proper version?

drscream commented 3 years ago

I would not recommend to remove the version spec, because somehow at $RANDOM it will break. Maybe we can go for:

djangorestframework-simplejwt>=4.4,<=4.6

So we've the tested versions 4.4 and 4.6?

mattLLVW commented 2 years ago

good call @drscream

mattLLVW commented 2 years ago

fixed in #399