latenitefilms / BRAWToolbox

Help & Support for BRAW Toolbox
https://brawtoolbox.io
MIT License
13 stars 1 forks source link

Plug-in is not responding when using potentially corrupt BMPCC4K clips #137

Closed spencedeezy closed 1 year ago

spencedeezy commented 1 year ago

Just Installed BRAW plugin on another desktop (2019 cheese grater mac, 16 core 3.2 GHz, 160GB RAM, AMD Radeon Pro 580X 8GB) and every time i try to use it, the plugin stops responding. I'm on FCPX 10.6.6 and I have the latest version of BRAW Toolbox V1.1.4

latenitefilms commented 1 year ago

That's strange! Can you please share your log files? See:

https://brawtoolbox.io/troubleshooting/#ive-run-into-a-bug-where-can-i-find-the-log-files

domrad1995 commented 1 year ago

Hi, I have the same issue. I had to close and reopen final on and on to work. But the more footage on timeline the worse, right now plugin stopped completely and is turning off right after reopening fcpx.

domrad1995 commented 1 year ago

here's m log file Application Support.zip

I will be thankfull for helping me with this :)

latenitefilms commented 1 year ago

I can't see any errors in those log files. Are there any crash reports you can share?

See: https://brawtoolbox.io/troubleshooting/#ive-run-into-a-bug-where-can-i-find-the-log-files

If there's no BRAW Toolbox crash logs, are there any Final Cut Pro crash logs?

It's entirely possible that Final Cut Pro is freaking out, rather than anything specific with BRAW Toolbox.

domrad1995 commented 1 year ago

Sure. There are braw toolbox crash logs, please find attached Archive.zip

domrad1995 commented 1 year ago

Final Cut also: Final Cut Pro-2023-06-19-162711.ips.zip I deleted all fcpx preferences but that didn't help :(

latenitefilms commented 1 year ago

Ummm... do you happen to have an older version of "Blackmagic RAW" or DaVinci Resolve installed by any chance?

If so, could you try installing the latest Blackmagic RAW 3.2?

It looks like the crash is happening in the Blackmagic RAW SDK, but I'm not exactly sure why.

I'll reach out to Blackmagic as well and see if they have any ideas.

domrad1995 commented 1 year ago

Ok thanks so much. I will add one thing maybe it will help you figure out. After couple times of window pop up with warning that plugin is not responding I realised that only one import stopped working (from different camera) which is BMPCC4K( but I'm not sure if it was upgraded or not, I will check it) but Import from second Pocket still works after warning.

domrad1995 commented 1 year ago

responding to your question, I have newest Davinci (beta) and after your comment I installed new Blackmagic Raw but it didn't help. Problem still exists and only with files from this particular BMPCC4K camera, so I think those files are the problem somehow.

latenitefilms commented 1 year ago

Can you share a clip that causes issues?

You can upload here:

https://latenitefilms.digitalpigeon.com

domrad1995 commented 1 year ago

Hi, I'm not sure which one of them is causing the problem, because it looks like all clips are loading and then - sometimes immediately after relaunch or after a while - plugin is not responding. 3 files are uploading, I just found one that is not opening witch blackmagic raw player, maybe that is the one causing the problem, but I don't know, I have 260 clips from festival, so it is hard to check for me all of them one by one.

Thanks for helping me with this.

wt., 20 cze 2023 o 18:44 Chris Hocking @.***> napisał(a):

Can you share a clip that causes issues?

You can upload here:

https://latenitefilms.digitalpigeon.com

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1599148789, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCW5CP72AXMEX2ZYVM3XMHHNVANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Interesting... it's possible there's a corrupt clip, and maybe that's causing the BRAW SDK to fail?

If you drag them all into DaVinci Resolve do they all work correctly?

domrad1995 commented 1 year ago

Yeah, when I drag them they all work correctly and the 2 small corrupted files are justnot imported. The next idea, is it possible that different fps could cause the problem? because on that camera sometimes I used 6 fps, or 10 fps for the blurry effect, and I had a feeling that this clips are difficult for fcpx to process.

wt., 20 cze 2023 o 23:33 Chris Hocking @.***> napisał(a):

Interesting... it's possible there's a corrupt clip, and maybe that's causing the BRAW SDK to fail?

If you drag them all into DaVinci Resolve do they all work correctly?

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1599593384, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCQ2E755WI5SHWDZLCLXMIJLJANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Anything is possible.

We use the official Blackmagic BRAW SDK for all the processing, so in theory, if it works in Blackmagic RAW Player and DaVinci Resolve it SHOULD work the same in BRAW Toolbox.

All our internal editing jobs with BRAW Toolbox are mainly a 25fps project/base rate and off-speeds like 50fps, 100fps, etc.

I couldn't see any errors in your previous logs, but if you can find files that consistently fail, then if you can send me the BRAW files, then I can work closely with Blackmagic to determine if it's a bug on their end or our end. But generally, all the actually PROCESSING is done in Blackmagic's code.

FWIW - I never got any BRAW files from you yet?

domrad1995 commented 1 year ago

I uploaded them yesterday via link you provided, I will do it again now. Thanks for answering my questions. If I find the files that consistently fail I will send them to you, but now it look like that plugin is randomly turning off.

latenitefilms commented 1 year ago

Opps, apologies - maybe I missed the email about the uploaded BRAW files. Will check again.

domrad1995 commented 1 year ago

No worries, right now, 5 more files should arrived. Today I tried couple times again to import those files and plugin is turning off almost right after moving import to library.

śr., 21 cze 2023 o 09:51 Chris Hocking @.***> napisał(a):

Opps, apologies - maybe I missed the email about the uploaded BRAW files. Will check again.

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1600359084, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCSH5LB76V5AYDAKHRDXMKRZRANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Got them - thanks! Will do some tests in a few hours time and see if I can reproduce. Stay tuned.

domrad1995 commented 1 year ago

Ok! Thanks! In touch.

śr., 21 cze 2023 o 10:08 Chris Hocking @.***> napisał(a):

Got them - thanks! Will do some tests in a few hours time and see if I can reproduce. Stay tuned.

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1600384966, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCUSAHPNZTLHPKCNH6DXMKTX5ANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Ok, so B001_03231617_C113 definitely has serious issues. It seems to crash the Workflow Extension - and shows no metadata. It won't even show a thumbnail in Finder, and doesn't load in Blackmagic RAW Player.

image image

B001_03231336_C055 and B001_03231445_C073 seem totally fine on my machine.

I'm on a MacBook Pro (16-inch, 2021, Apple M1 Max, 64GB RAM, 3TB SSD, Monterey v12.6.6, FCPX v10.6.6).

All the other files on your second link (B001_03241216_C166, B001_03241219_C170, B001_03241219_C171, B001_03241224_C178 and B001_03241225_C180) also seem to play fine on my machine:

image

Everything plays back super fast and responsive, I've tried duplicating the clips many times to make a massive timeline, and everything seems to be working fine.

image
domrad1995 commented 1 year ago

Yeah 113 isn't opening even in Resolve. I also have Macbook Pro M1. I have 260 clips from this camera, so I don't no which one is causing the problems. I already made selection in Resolve, I will export Prores422 in the old way. I will try to upgrade camera, maybe that will help. If I will find out what is causing the problem I will let you know. Thanks for your help.

Kind regards, Dominik

śr., 21 cze 2023 o 15:57 Chris Hocking @.***> napisał(a):

Ok, so B001_03231617_C113 definitely has serious issues. It seems to crash the Workflow Extension - and shows no metadata. It won't even show a thumbnail in Finder, and doesn't load in Blackmagic RAW Player. [image: image] https://user-images.githubusercontent.com/22286696/247571196-5c225a6e-d415-40c2-b3af-779a3c09fe2f.png [image: image] https://user-images.githubusercontent.com/22286696/247571293-54c01cae-0d27-4a23-b051-a900a4245593.png

B001_03231336_C055 and B001_03231445_C073 seem totally fine on my machine.

I'm on a MacBook Pro (16-inch, 2021, Apple M1 Max, 64GB RAM, 3TB SSD, Monterey v12.6.6, FCPX v10.6.6).

All the other files on your second link (B001_03241216_C166, B001_03241219_C170, B001_03241219_C171, B001_03241224_C178 and B001_03241225_C180) also seem to play fine on my machine: [image: image] https://user-images.githubusercontent.com/22286696/247572351-e148f897-7bf3-4df0-b0e6-b1e88dafdacb.png

Everything plays back super fast and responsive, I've tried duplicating the clips many times to make a massive timeline, and everything seems to be working fine. [image: image] https://user-images.githubusercontent.com/22286696/247573482-603f5ecf-6d6d-4d1c-8807-be7766fed65d.png

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1600886600, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCS7OB6HFWIFFLSCITDXML4ULANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Are there other clips in the folder that aren't showing a thumbnail in Finder like B001_03231617_C113?

domrad1995 commented 1 year ago

Only 2. I will record my screen and send it to you. You will see better what is going on.

śr., 21 cze 2023 o 16:09 Chris Hocking @.***> napisał(a):

Are there other clips in the folder that aren't showing a thumbnail in Finder like B001_03231617_C113?

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1600909182, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCXT4QNLCKH6NEEJIKTXML6CRANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Legend, thanks! That's really helpful.

In this screen recording there doesn't seem to be anything wrong with the BRAW processing - it looks like all the metadata is being correctly loaded into Workflow Extension, and it looks like everything is playing nicely in Final Cut Pro... until it starts to slow down, due to all the thumbnail generation happening, and eventually the plugin just stops.

My only GUESS is that Final Cut Pro is trying to do too much at the same time, and basically gives up, and aborts the plugin. It might have some kind of internal timeout feature, and if the plugin is taking too long, it pulls the plug?

Have you tried importing ~60 clips at a time into different events and seen if that has any impact?

Also, have you tried using a lower decode quality? I wonder if Final Cut Pro is just running out of system resources when trying to render thumbnails for 115 x 4K BRAW files all at once?

I think there's definitely some work we can do in terms of the corrupt clip (B001_03231617_C113) - I THINK this is probably a problem on the Workflow Extension side, rather than anything in the Blackmagic RAW SDK. I'll address this in #140.

However, the "A plugin is not responding" issue seems unrelated. I'll reach out to the Final Cut Pro team and see if they have any insight.

domrad1995 commented 1 year ago

Ok, that's great.

Ok I used half decoding now and - I tried 40 clips and it was ok. I added another 50 clips more and... plugin is not responding.

Thanks for reaching out to FCPX. I hope they will have an answer soon.

śr., 21 cze 2023 o 16:26 Chris Hocking @.***> napisał(a):

Legend, thanks! That's really helpful.

In this screen recording there doesn't seem to be anything wrong with the BRAW processing - it looks like all the metadata is being correctly loaded into Workflow Extension, and it looks like everything is playing nicely in Final Cut Pro... until it starts to slow down, due to all the thumbnail generation happening, and eventually the plugin just stops.

My only GUESS is that Final Cut Pro is trying to do too much at the same time, and basically gives up, and aborts the plugin. It might have some kind of internal timeout feature, and if the plugin is taking too long, it pulls the plug?

Have you tried importing ~60 clips at a time into different events and seen if that has any impact?

Also, have you tried using a lower decode quality? I wonder if Final Cut Pro is just running out of system resources when trying to render thumbnails for 115 x 4K BRAW files all at once?

I think there's definitely some work we can do in terms of the corrupt clip (B001_03231617_C113) - I THINK this is probably a problem on the Workflow Extension side, rather than anything in the Blackmagic RAW SDK. I'll address this in #140 https://github.com/latenitefilms/BRAWToolbox/issues/140.

However, the "A plugin is not responding" issue seems unrelated. I'll reach out to the Final Cut Pro team and see if they have any insight.

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1600941151, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCSLKHA7G2GC4MGFLBLXMMABBANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

FYI - I've fixed the Workflow Extension crash that was caused by a corrupt clip like B001_03231617_C113. Thanks for reporting!

latenitefilms commented 1 year ago

Ummm... if you look at Activity Monitor when you're importing these 90 clips, is RAM being pushed at all? How fast is the drive you're working off? We've imported a lot more than 90 clips and have never had any issues, so it's hard to work out exactly why it would be failing. We're generally working off fast SSDs though.

domrad1995 commented 1 year ago

Ok, I think we've got the answer(probably). So I have only 500 gb ssd on my macbook and 16 gb ram. Disk was almost full, so I cleared space and it looks like it is working fine, but it did crash one time after import, so I will see... When importing 180 clips (quarter res decoding) it took 55% CPU in activity monitor.

śr., 21 cze 2023 o 16:51 Chris Hocking @.***> napisał(a):

Ummm... if you look at Activity Monitor when you're importing these 90 clips, is RAM being pushed at all? How fast is the drive you're working off? We've imported a lot more than 90 clips and have never had any issues, so it's hard to work out exactly why it would be failing. We're generally working off fast SSDs though.

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1600986166, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCRT36U3LONM44BT4D3XMMC73ANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

BRAW Toolbox v1.2.1 (53) is out now, which fixes the Workflow Extension crash. Thanks again!

I'm still chatting with Blackmagic and Apple to try and work out what's going on with the plugin not responding.

In the meantime Apple did mention this about one of the crash logs you provided:

I did notice there’s also a crash log from FCP which isn’t directly related to this crash. It’s from about an hour and a half earlier than the crash logs of your plug-in. The crash log says this is the problem:

3 Final Cut Pro 0x0000000104602474 +[PEDocument failureToCloseUndoScope:] + 504

That looks like an error on our part and I’d like to understand what caused it. Would you be able to contact the user and see if they can remember what they were doing when it happened? If it’s related to a plug-in crashing, it may be that we aren’t always handling a crashed plug-in properly. If that is the case, I’d like to find a way to reproduce and fix the issue. But I understand if it’s not possible to get that info from the user.

Any ideas?

latenitefilms commented 1 year ago

I've also just submitted BRAW Toolbox v1.2.2 (54) to the Mac App Store for review which adds a whole bunch of checks to make sure that the data we're getting back from the Blackmagic RAW SDK is all correct and valid, in the off-chance that maybe the SDK is sending bad data. Hopefully it gets approved quickly and you can test it out.

latenitefilms commented 1 year ago

BRAW Toolbox v1.2.2 (54) is out now!

If you still have any "not responding" messages, can you please resupply all your log files and crash logs? Thanks!

domrad1995 commented 1 year ago

Hi, thats great news! I hope that will solve the problem. I will try to test that out today's afternoon because right now I have to go on recce. I will let you know as soon as possible! Thanks! Regards

czw., 22 cze 2023 o 01:20 Chris Hocking @.***> napisał(a):

BRAW Toolbox v1.2.2 (54) is out now!

If you still have any "not responding" messages, can you please resupply all your log files and crash logs? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1601813947, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCXE45Y74QK5ECGSKUTXMN6VRANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

domrad1995 commented 1 year ago

Hi, so sorry for late response, I was out doing multiple things. I think that your previous idea about clearing space and force decoding lower ( I had force full quality before) helped. After update it looks like there are no crashes. Many thanks! Your support was awesome!

czw., 22 cze 2023 o 09:35 Dominik Radecki @.***> napisał(a):

Hi, thats great news! I hope that will solve the problem. I will try to test that out today's afternoon because right now I have to go on recce. I will let you know as soon as possible! Thanks! Regards

czw., 22 cze 2023 o 01:20 Chris Hocking @.***> napisał(a):

BRAW Toolbox v1.2.2 (54) is out now!

If you still have any "not responding" messages, can you please resupply all your log files and crash logs? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1601813947, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCXE45Y74QK5ECGSKUTXMN6VRANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460

latenitefilms commented 1 year ago

Great news! I'll close this issue for now, but yell out if you have any issues.

domrad1995 commented 1 year ago

Ok, great. Thanks!

wt., 27 cze 2023 o 02:56 Chris Hocking @.***> napisał(a):

Great news! I'll close this issue for now, but yell out if you have any issues.

— Reply to this email directly, view it on GitHub https://github.com/latenitefilms/BRAWToolbox/issues/137#issuecomment-1608542653, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAVJCCS6QNJ3TEJGDMJ52ODXNIVTBANCNFSM6AAAAAAZFWMSKI . You are receiving this because you commented.Message ID: @.***>

-- Z wyrazami szacunku,

Dominik Radecki https://vimeo.com/dominikradecki @.*** +48502488460