latestchatty / chromeshack

Browser extension containing various scripts that enhance the Shacknews comments
http://adam.hughes.cc/shack/chromeshack/
MIT License
27 stars 16 forks source link

Proper support for multi-item embeds (Imgur/Instagram) #104

Closed WombatFromHell closed 5 years ago

WombatFromHell commented 5 years ago

"Embed Social Links" and "Embed Image Links" scripts already mostly support this we just need proper Carousel functionality. I'm pretty sure this can be done with pure CSS3.

(Edit: It totally can't be done with only CSS3, as there wouldn't be accurate state tracking. I'm using Flickity for this in my PR #107, but Swiper is another mature alternative.)

WombatFromHell commented 5 years ago

Examples of some multi-item Instagram posts:

https://www.shacknews.com/chatty?id=38150327#item_38150327 (static)

https://www.shacknews.com/chatty?id=38095389#item_38095389 (static)

https://www.shacknews.com/chatty?id=38120226#item_38120226 (both static and video content here)

Edit: ... as well as some Imgur posts:

https://www.shacknews.com/chatty?id=38156304#item_38156304 (static gallery)

https://www.shacknews.com/chatty?id=38153313#item_38153313 (video gallery)

Edit 2: ... and some more Imgur posts:

https://www.shacknews.com/chatty?id=38104703#item_38104703 (multi-gallery multi-item)

https://www.shacknews.com/chatty?id=38175484#item_38175484 (large multi-item gallery with varying sizes)

WombatFromHell commented 5 years ago

Should be fixed by 7319606.