latex3 / hyperref

Hypertext support for LaTeX
168 stars 37 forks source link

cleveref broken #365

Open jwuttke opened 1 day ago

jwuttke commented 1 day ago

Debian package texlive-latex-base, version 2024.20241102-1 broke my manuscript, which is based on siamart220329 from journal publisher SIAM.

From the log:

$ pdflatex cgt0
This is pdfTeX, Version 3.141592653-2.6-1.40.26 (TeX Live 2025/dev/Debian) (preloaded format=pdflatex)
 restricted \write18 enabled.
entering extended mode
(./cgt0.tex
LaTeX2e <2024-11-01>
L3 programming layer <2024-10-09>
(./siamart220329.cls
Document Class: siamart220329 2022/03/29 v1.4.4 LaTeX document e-class
(/usr/share/texlive/texmf-dist/tex/latex/amsmath/amsmath.sty
For additional information on amsmath, use the `?' option.
(/usr/share/texlive/texmf-dist/tex/latex/amsmath/amstext.sty
(/usr/share/texlive/texmf-dist/tex/latex/amsmath/amsgen.sty))
(/usr/share/texlive/texmf-dist/tex/latex/amsmath/amsbsy.sty)
(/usr/share/texlive/texmf-dist/tex/latex/amsmath/amsopn.sty))
(/usr/share/texlive/texmf-dist/tex/latex/ntheorem/ntheorem.sty
Style `ntheorem', Version 1.33 <2011/08/15>
(/usr/share/texlive/texmf-dist/tex/latex/base/ifthen.sty))
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/xr-hyper.sty)
(/usr/share/texlive/texmf-dist/tex/generic/iftex/ifpdf.sty
(/usr/share/texlive/texmf-dist/tex/generic/iftex/iftex.sty))
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/hyperref.sty
(/usr/share/texlive/texmf-dist/tex/latex/graphics/keyval.sty)
(/usr/share/texlive/texmf-dist/tex/latex/kvsetkeys/kvsetkeys.sty)
(/usr/share/texlive/texmf-dist/tex/generic/kvdefinekeys/kvdefinekeys.sty)
(/usr/share/texlive/texmf-dist/tex/generic/pdfescape/pdfescape.sty
(/usr/share/texlive/texmf-dist/tex/generic/ltxcmds/ltxcmds.sty)
(/usr/share/texlive/texmf-dist/tex/generic/pdftexcmds/pdftexcmds.sty
(/usr/share/texlive/texmf-dist/tex/generic/infwarerr/infwarerr.sty)))
(/usr/share/texlive/texmf-dist/tex/latex/hycolor/hycolor.sty)
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/nameref.sty
(/usr/share/texlive/texmf-dist/tex/latex/refcount/refcount.sty)
(/usr/share/texlive/texmf-dist/tex/generic/gettitlestring/gettitlestring.sty
(/usr/share/texlive/texmf-dist/tex/latex/kvoptions/kvoptions.sty))

Package nameref Warning: The definition of \label has changed!
(nameref)                Check your packages!
(nameref)                Replacing it with the kernel definition on input line
149.

) (/usr/share/texlive/texmf-dist/tex/latex/etoolbox/etoolbox.sty)
(/usr/share/texlive/texmf-dist/tex/generic/stringenc/stringenc.sty)
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/pd1enc.def)
(/usr/share/texlive/texmf-dist/tex/generic/intcalc/intcalc.sty)
(/usr/share/texlive/texmf-dist/tex/latex/hyperref/puenc.def)
(/usr/share/texlive/texmf-dist/tex/latex/url/url.sty)

...

Package hyperref Warning: The anchor of a bookmark and its parent's must not
(hyperref)                be the same. Added a new anchor on input line 127.

LaTeX Warning: cref reference format for label type `' undefined on input line
171.

LaTeX Warning: cref reference format for label type `' undefined on input line
179.

Seen the patch https://github.com/latex3/hyperref/commit/fffd2e030c7aff952c0e9f34265fe4a03a8efd46, I inserted

  \AddToHook{package/cleveref/after}
   {
     \@ifpackagelater{cleveref}{2018/03/28}{}
      {
      \NewSocketPlug{refstepcounter}{hyperref/fixcleveref}
       {\ifHy@pdfstring\else
         #1%
         {\firstaid@cref@updatelabeldata{\@currentcounter}}%
        \fi}
       \AssignSocketPlug{refstepcounter}{hyperref/fixcleveref}
      }
   }

to hyperref.sty, but the bug stayed.

u-fischer commented 1 day ago

Report that to the class, see also https://tex.stackexchange.com/a/730631/2388