search

latex3 / l3build

A testing and building system for LaTeX
LaTeX Project Public License v1.3c
88 stars 14 forks source link

Stick to third-person singular form in target and option docs #340

Closed muzimuzhi closed 8 months ago

muzimuzhi commented 9 months ago

Hmm the "Co-authored-by" trailers in git commit messages don't work as expected.

josephwright commented 8 months ago

We good to go here?

car222222 commented 8 months ago

@josephwright (I guess).

The major problem with the \ASSERT item in this list is that it does not say anything about what actually gets written to the log file.

Thus it seems to need a total rewrite.
Or am I missing something?

josephwright commented 8 months ago

@car222222 Well perhaps but that's a separate issue - suggest we agree on the PR here then I re-work that sentence later.

car222222 commented 8 months ago

@josephwright Agreed that this is something else again!
Therefore I did approve this PR.

car222222 commented 8 months ago

My comment on Lines 594-6 got mangled a bit, try this instead.

Applies the Lua |update_tag()| function to modify the contents of all the files specified by |tagfiles|; this function updates the `release tag' (or package version) and the date.

josephwright commented 8 months ago

My comment on Lines 594-6 got mangled a bit, try this instead.

@car222222 Added as 0231d16f933a21ddb6bc0b78f780fb93546a79ed

josephwright commented 8 months ago

Well perhaps but that's a separate issue - suggest we agree on the PR here then I re-work that sentence later.

@car222222 3e8067ea3901b5db759f06f46a0eb411331a7568

car222222 commented 8 months ago

I think that a space got lost in 0231d16, should be "; this". Probably my fault.