latex3 / latex2e

The LaTeX2e kernel

https://www.latex-project.org/

LaTeX Project Public License v1.3c

1.95k stars 267 forks source link

Add support for "\={i}" to OT1 and T1 #1535

Closed josephwright closed 2 weeks ago

josephwright commented 3 weeks ago

Internal housekeeping

Status of pull request

Feedback wanted
Under development
[x] Ready to merge

Checklist of required changes before merge will be approved

[ ] Test file(s) added
[x] Version and date string updated in changed source files
[x] Relevant \changes entries in source included
[x] Relevant changes.txt updated
[ ] Rollback provided (if necessary)?
[ ] ltnewsX.tex (and/or latexchanges.tex) updated

I'm not seeing a need for rollback here or a news entry as this is an edge case - but if I'm wrong, do say!

josephwright commented 3 weeks ago

approved, but something fails in the source2e documentation

I'll look - I guess \changes

josephwright commented 3 weeks ago

Ah, it's the = - suggested alternative to

% \changes{v2.1b}{2024/11/04}{Support \cs{=}\cs{i} for OT1}

FrankMittelbach commented 3 weeks ago

Ah, it's the = - suggested alternative to
% \changes{v2.1b}{2024/11/04}{Support \cs{=}\cs{i} for OT1}
?

what is breaking there?

josephwright commented 3 weeks ago

what is breaking there?

From source2e.gls:

  \item 2024-11-04 ltoutenc.dtx v2.1b\efill 
 \subitem General:\ }\cs {i} for T1\pfill \hdpindex{}{490}

davidcarlisle commented 2 weeks ago

gind.ist makes = the actual-char. \changes... support i-macron accent in OT1 would avoid falling over =

FrankMittelbach commented 2 weeks ago

gind.ist makes = the actual-char. \changes... support i-macron accent in OT1 would avoid falling over =

ah, as simple as that. But I though macros are entred with quote chars in front of everything ...hmm, anyway, changing the text is certainly easy enough for now.

josephwright commented 2 weeks ago

OK now?