search

latex3 / tagging-project

Issues related to the tagging project
https://latex3.github.io/tagging-project/
LaTeX Project Public License v1.3c
23 stars 5 forks source link

longtable table with \hline #38

Closed dpantele closed 2 weeks ago

dpantele commented 7 months ago

For some reason uncommenting any \hline there results in an error:

\DocumentMetadata{testphase={phase-III,math,table},pdfversion=2.0,pdfstandard=A-4}
\documentclass{article}

\usepackage{longtable}

\title{test_synctex}
\author{dpantele }
\date{November 2023}

\begin{document}

\begin{longtable}[c]{| c | c |}
 \caption{Long table caption.\label{long}}\\

 %\hline
 \multicolumn{2}{| c |}{Begin of Table}\\
 %\hline
 Something & something else\\
 %\hline
 \endfirsthead

 %\hline
 \multicolumn{2}{|c|}{Continuation of Table \ref{long}}\\
 %\hline
 Something & something else\\
 %\hline
 \endhead

 %\hline
 \endfoot

 %\hline
 \multicolumn{2}{| c |}{End of Table}\\
 %\hline\hline
 \endlastfoot

 Lots of lines & like this\\
 Lots of lines & like this\\
\end{longtable}

\end{document}

Error"

./test_synctex.tex:41: Undefined control sequence.
<argument> \ERROR 

l.41 \end
       {longtable}

Regular tabular works fine with hilne.

u-fischer commented 7 months ago

I get no error. Show your log-file.

josephwright commented 7 months ago

@u-fischer I see the error: file list

 *File List*
documentmetadata-support.ltx
pdfmanagement-testphase.sty    2023-11-17 v0.96c LaTeX PDF management testphase
 bundle
tagpdf-base.sty    2023-11-19 v0.98q part of tagpdf - provide base, no-op versi
ons of the user commands 
pdfmanagement-testphase.ltx    2023-11-17 v0.96c PDF management code (testphase
)
l3bitset.sty    2023-11-01 L3 Experimental bitset support
l3backend-luatex.def    2023-11-04 L3 backend support: PDF output (LuaTeX)
l3backend-testphase-luatex.def    2023-11-17 LaTeX PDF management testphase bun
dle backend support:PDFoutput(LuaTeX)
phase-III-latex-lab-testphase.ltx    2023-07-20 v0.1b latex-lab wrapper phase-I
II
phase-II-latex-lab-testphase.ltx    2023-06-15 v0.1b latex-lab wrapper phase-II

latex-lab-testphase-new-or-1.sty    2023-07-20 v0.85a Temporary output patches 
for tagging and better link support
etoolbox.sty    2020/10/05 v2.5k e-TeX tools for LaTeX (JAW)
latex-lab-testphase-new-or-2.sty    2023-09-04 v0.85c Changes to the output rou
tine
latex-lab-footnotes.ltx    2023-09-04 v0.8c changes to the footnote interfaces
  tagpdf.sty    2023-11-19 v0.98q  A package to experiment with pdf tagging 
tagpdf-luatex.def    2023-11-19 v0.98q tagpdf driver for luatex
tagpdf-mc-code-lua.sty    2023-11-19 v0.98q tagpdf - mc code only for the luamo
de 
latex-lab-testphase-block.sty    2023-09-01 v0.8h blockenv implementation
xtemplate.sty    2023-10-10 L3 Experimental prototype document functions
   expl3.sty    2023-11-09 L3 programming layer (loader) 
latex-lab-kernel-changes.sty    2023-10-16 v0.85b General kernel and class chan
ges
glyphtounicode.tex
glyphtounicode-cmex.tex
latex-lab-testphase-sec.sty    2023-10-16 v0.84b Code related to the tagging of
 sectioning commands
latex-lab-testphase-toc.sty    2023-10-16 v0.85b  Code related to the tagging o
f toc-like lists
latex-lab-testphase-minipage.sty    2023-10-30 v0.81c Code related to the taggi
ng of minipages and parboxes
latex-lab-testphase-graphic.sty    2023-10-13 v0.80b Code related to the taggin
g of graphics
l3opacity.sty    2023-11-01 L3 Experimental opacity support
latex-lab-testphase-float.sty    2023-07-20 v0.81a Code related to the tagging 
of floats
latex-lab-testphase-bib.sty    2023-07-20 v0.81a Code related to the tagging of
 bibliography and cite command
latex-lab-testphase-text.sty    2023-07-20 v0.85a Code related to the tagging o
f various small text commands
math-latex-lab-testphase.ltx    2023-07-20 v0.8a latex-lab wrapper math
latex-lab-testphase-math.sty    2023-07-20 v0.8a code related to the math taggi
ng
latex-lab-math.ltx    2023-09-11 v0.5c Grab all the math(s) and tag it (experim
ents)
latex-lab-amsmath.ltx    2023-01-05 v0.1a amsmath adaptions
latex-lab-mathtools.ltx    2023-01-05 v0.1a mathtools adaptions
latex-lab-mathpkg.ltx    2023-01-05 v0.1a mathpkg adaptions
table-latex-lab-testphase.ltx    2023-10-30 v0.85d latex-lab wrapper table
latex-lab-testphase-table.sty    2023-10-30 v0.85d Code related to the tagging 
of tables
   array.sty    2023/10/16 v2.5g Tabular extension package (FMi)
pdfmanagement-firstaid.sty    2023-11-17 v0.96c LaTeX PDF management testphase 
bundle / firstaid-patches
 article.cls    2023/05/17 v1.4n Standard LaTeX document class
  size10.clo    2023/05/17 v1.4n Standard LaTeX file (size option)
longtable.sty    2023-11-01 v4.19 Multi-page Table package (DPC)
  ts1cmr.fd    2023/04/13 v2.5m Standard LaTeX font definitions
 amsmath.sty    2023/05/13 v2.17o AMS math features
 amstext.sty    2021/08/26 v2.01 AMS text
  amsgen.sty    1999/11/30 v2.0 generic functions
  amsbsy.sty    1999/11/29 v1.2d Bold Symbols
  amsopn.sty    2022/04/08 v2.04 operator names
 ***********
u-fischer commented 7 months ago

Oh an example where I have to uncomment something to get the error ;-( Ok. I can now see the error too.

u-fischer commented 7 months ago

@FrankMittelbach \LT@@hline contains two \multispan and they increase the row count \g__tbl_row_int by 2. This must be undone.

\def\LT@@hline{%
  \ifx\@let@token\hline
    \global\let\@gtempa\@gobble
    \gdef\LT@sep{\penalty-\@medpenalty\vskip\doublerulesep}%
  \else
    \global\let\@gtempa\@empty
    \gdef\LT@sep{\penalty-\@lowpenalty\vskip-\arrayrulewidth}%
  \fi
  \ifnum0=`{\fi}%
  \multispan\LT@cols
     \unskip\leaders\hrule\@height\arrayrulewidth\hfill\cr
  \noalign{\LT@sep}%
  \multispan\LT@cols
     \unskip\leaders\hrule\@height\arrayrulewidth\hfill\cr
  \noalign{\penalty\@M}%
  \@gtempa}
FrankMittelbach commented 6 months ago

I have this now corrected in the new implementation I'm working on, should show up with the next release of latex-dev, but probably not before Xmas

dpantele commented 6 months ago

Thanks ! The fix is not submitted yet, is it?

u-fischer commented 6 months ago

it is in a branch but not in develop yet.

kellijohnson-NOAA commented 3 months ago

I am not sure if the additional example is helpful or not but I am also getting errors when using longtable with \toprule and \midrule. I can cycle through the warnings, which leads to a pdf, but they go away on the command line if I remove the \toprule and \midrule calls in the .tex file. I know that the original issue has been fixed in the development version but I just thought that a slight variation on the original example might be helpful for ensuring that the proposed fix works in more cases. Sorry that I am unable to install the development version to test it myself.

\DocumentMetadata{%
 testphase={phase-III, tabular}
}
\documentclass[11pt,
  letterpaper,
]{article}
\usepackage{amsmath,amssymb,array}
\usepackage{booktabs}
\usepackage{longtable}

\begin{document}

\begin{longtable}[t]{r>{\centering\arraybackslash}p{1.83cm}>{\centering\arraybackslash}p{1.83cm}>{\centering\arraybackslash}p{1.83cm}>{\centering\arraybackslash}p{1.83cm}>{\centering\arraybackslash}p{1.83cm}}
\caption{\label{tab:south-removalsES}This is my caption.}\\
\toprule
Year & Commercial Dead & Commercial Live & Rec CPFV & Rec PR & Total Catch\\
\midrule
\endfirsthead
\caption[]{This is a shorter caption. \textit{(continued)}}\\
\toprule
Year & Commercial Dead & Commercial Live & Rec CPFV & Rec PR & Total Catch\\
\midrule
\endhead
\endfoot
\bottomrule
\endlastfoot
2013 & 1.26 & 2.67 & 61.65 & 13.96 & 79.54\\
2014 & 1.79 & 2.29 & 47.58 & 10.04 & 61.71\\
2022 & 0.69 & 0.21 & 14.12 & 4.50 & 19.52\\*
\end{longtable}
\end{document}

The log file is attached below. test.log

u-fischer commented 3 months ago

@kellijohnson-NOAA no your problem is different and specific to the booktabs package. I opened a new issue for it https://github.com/latex3/tagging-project/issues/69