latex3 / tagging-project

Issues related to the tagging project
https://latex3.github.io/tagging-project/
LaTeX Project Public License v1.3c
36 stars 14 forks source link

marginfix package incompatible #547

Open mbertucci47 opened 1 month ago

mbertucci47 commented 1 month ago

Using the marginfix package with the tagging code always leads to

! Package marginfix Error: lost some margin notes.

Example:

\DocumentMetadata
  {
    lang=en-US,
    pdfversion=2.0,
    pdfstandard=ua-2,
    testphase={phase-III,title,math,table,firstaid}
  }
\documentclass{article}

\usepackage{marginfix}

\begin{document}

text\marginpar{margin text}

\end{document}
u-fischer commented 1 month ago

It errors already if only new-or is loaded. The problem is that it patches \@combinefloats to prepend its command but that is not used. If one copy the definition it looks fine:

\DocumentMetadata
  {
    lang=en-US,
    pdfversion=2.0,
    testphase={phase-III}
  }
\documentclass{article}
\usepackage{marginfix}
\makeatletter\let\@outputbox@attachfloats \@combinefloats\makeatother
\begin{document}
\reversemarginpar

text\marginpar{margin text}
\marginpar[blub]{margin text}

text 2 

text 3
\end{document}

Main question is if an interface is needed...