search

lathonez / clicker

Ionic 2 + @angular/cli Seed Project : Angular2 + Typescript + Karma + Protractor + Travis
http://lathonez.com/2018/ionic-2-unit-testing/
MIT License
430 stars 137 forks source link

Update deps #230

Closed mchapman closed 7 years ago

lathonez commented 7 years ago

Thanks for this.

Unfortunately it generally isn't as simple as updating node package versions.

You also need to check for breaking config changes in angular-cli and Ionic.

Looking at the CI errors it seems to be an issue with angular-cli.

I will take a look on Monday.

lathonez commented 7 years ago

The angular/cli upgrade was pretty big: 13a6cd6

I couldn't get around upgrading Angular to 2.4.0, the tests wouldn't run without it. However that means you get a pretty nasty peer dependency warning on npm install.

Just waiting for CI to fail on the above..

lathonez commented 7 years ago

Closing as above