search

lathonez / clicker

Ionic 2 + @angular/cli Seed Project : Angular2 + Typescript + Karma + Protractor + Travis
http://lathonez.com/2018/ionic-2-unit-testing/
MIT License
430 stars 137 forks source link

upgrade to ionic 2.3.0 #237

Closed ghost closed 7 years ago

ghost commented 7 years ago

If you could upgrade the repository to version 2.3.0 of ionic that would help people with the newest version of ionic have confidence that this repository is still being maintained. Thanks

lathonez commented 7 years ago

Hi Jason,

We'll be looking at the upgrade early next week. If you'd like to contribute, feel free to make a PR.

Thanks,

Stephen

ghost commented 7 years ago

I'll see if I can get the time to contribute by next week. If I do feel free to let me know if I'm doing something wrong.

lathonez commented 7 years ago

Thanks a lot for your input Jason. It would be great to have a contribution from you.

Re the broken upgrade on @angular/cli - you really need to make a new app using the cli and compare everything when upgrading versions. There are often a lot of config changes. I meld the two apps when I do this.

Same process for Ionic upgrades.

On Thu, 23 Mar 2017 at 14:53, Jason Wayne Gallavin notifications@github.com wrote:

I'll see if I can get the time to contribute by next week. If I do feel free to let me know if I'm doing something wrong.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/lathonez/clicker/issues/237#issuecomment-288610384, or mute the thread https://github.com/notifications/unsubscribe-auth/AG5tSM8xc57tgo_NljCl1fgQ3WHSK052ks5roeywgaJpZM4MmHde .

murraybauer commented 7 years ago

@lathonez This ionic testing example repo was released recently by ionic themselves with unit tests added and a pending PR to add e2e testing. May be of use or reference.

https://github.com/driftyco/ionic-unit-testing-example

lathonez commented 7 years ago

@murraybauer wow I had no idea this existed! I can finally deprecate this repo. Thanks a lot for the link.

I'm also hoping the Ionic guys will reference all my hard work :sweat_smile:

I'm going to raise an issue to deprecate this repo now.

lathonez commented 7 years ago

closing in favour of #239

murraybauer commented 7 years ago

@lathonez no probs. It's worth following Max on twitter :-) . I think we're yet still yet to see an offical announcement. Appreciate your efforts to date and desire to merge/contribute learnings to hopefully an offical toolkit.