lathonez / clicker

Ionic 2 + @angular/cli Seed Project : Angular2 + Typescript + Karma + Protractor + Travis
http://lathonez.com/2018/ionic-2-unit-testing/
MIT License
430 stars 137 forks source link

Brings coverage of unit tests up to 100 per cent #243

Closed hfwittmann closed 7 years ago

hfwittmann commented 7 years ago

Hi Stephen, here is my pull request, which brings the coverage of the unit tests up to 100%. Best, Felix

codecov[bot] commented 7 years ago

Codecov Report

Merging #243 into master will increase coverage by 1.71%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #243      +/-   ##
========================================
+ Coverage   94.28%    96%   +1.71%     
========================================
  Files          16     16              
  Lines         175    175              
  Branches        6      6              
========================================
+ Hits          165    168       +3     
+ Misses          2      0       -2     
+ Partials        8      7       -1
Impacted Files Coverage Δ
src/services/clickers.ts 98.11% <100%> (+1.88%) :arrow_up:
src/services/storage.ts 100% <0%> (+7.69%) :arrow_up:
src/pages/page2/page2.ts 100% <0%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b400e7...3e2551f. Read the comment docs.

lathonez commented 7 years ago

Thanks Felix!