lathonez / clicker

Ionic 2 + @angular/cli Seed Project : Angular2 + Typescript + Karma + Protractor + Travis
http://lathonez.com/2018/ionic-2-unit-testing/
MIT License
430 stars 137 forks source link

clean up #244

Closed hfwittmann closed 7 years ago

hfwittmann commented 7 years ago

remove unneccesary import

hfwittmann commented 7 years ago

I am not sure what's gone wrong. I only tried to delete one line in storage.spec.ts, namely

import { StorageMock } from './mocks';

Locally all the tests run fine. Should I try again?

lathonez commented 7 years ago

Appveyor failed to load the webdriver, despite it being in the post install npm steps and being called explicitly before the tests run.

No idea why. Am rebuilding now (just to see what happens).

Will merge this regardless shortly. Thanks for the contribution

codecov[bot] commented 7 years ago

Codecov Report

Merging #244 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #244   +/-   ##
=====================================
  Coverage      96%    96%           
=====================================
  Files          16     16           
  Lines         175    175           
  Branches        6      6           
=====================================
  Hits          168    168           
  Partials        7      7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6268157...daa3172. Read the comment docs.

lathonez commented 7 years ago

.. just rebuilding sorted it 👏 appveyor.

hfwittmann commented 7 years ago

Excellent