AlertController

[hfwittmann]

Hi Stephen,

would you be interested in incorporating an alert/alert controller example? If so, I could provide one (including 100% coverage).

Or would you say: interesting, but this constitutes mission creep?

Cheers Felix

[kamok]

What does an alert/alert controller example entail?

[hfwittmann]

Among other things it counts/checks the clicks on the elements, such as OK and Dismiss;

[kamok]

I just don't understand why you wrote tests. You mean you wrote an AlertController mock? If so I'd be interested in seeing a functional one. I believe currently you can't just import AlertController and use it in your Test Bed.

[hfwittmann]

I did, but you are not Stephen, are you?

On Jun 8, 2017 5:39 PM, "Ka Mok" notifications@github.com wrote:

I just don't understand why you wrote tests. You mean you wrote an AlertController mock? If so I'd be interested in seeing a functional one. I believe currently you can't just import AlertController and use it in your Test Bed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lathonez/clicker/issues/251#issuecomment-307142224, or mute the thread https://github.com/notifications/unsubscribe-auth/AFy9Lxh9ElDH4Yu-zkXT0VWGQqKeyLoCks5sCBW7gaJpZM4Nz5ia .

[kamok]

No this is not Stephen. I was just reading the Issues to see if anyone documented an Issue I found.

[hfwittmann]

Ok, excellent, I'll wait to hear what he says...

[lathonez]

Hey Felix,

I have one too in another project - it was fiddly enough to set it up iirc.

I think it would be helpful. Would be great if you could do a PR? Maybe something on Page2 that triggers the alert. We've used that page for examples like that in the past.

Cheers

On Fri, 9 Jun 2017 at 02:16, Felix Wittmann notifications@github.com wrote:

Ok, excellent, I'll wait to hear what he says...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lathonez/clicker/issues/251#issuecomment-307153254, or mute the thread https://github.com/notifications/unsubscribe-auth/AG5tSENpmHFu55WaxbCdXfVmyJ27otYUks5sCB50gaJpZM4Nz5ia .

[hfwittmann]

Excellent, I'll get onto that, probably today..

[lathonez]

closed in #252 thanks a lot Felix