Closed hfwittmann closed 7 years ago
Thanks Felix.
Please see the above CI failures. Travis is one to look at - Appveyor has a bit of a mind of it's own.
I can see the following issues:
If you can resolve these we can get it merged in.
Cheers
Hi Stephen,
thanks for the info.
I have now corrected
a) the linting issues b) the e2e test: page2.e2e-spec.ts
As for the unit tests, one of the files had not been pulled.
I have now doubly checked everything works as expected, by pulling directly from my fork like this:
This step fails initially, and has to be run again.
Remark: I think this might be an ionic issue. ( It complains about the postinstall script failing). I think there was an issue with the build last time....
So fingers crossed...
Cheers, Felix
Hi Stephen,
so here it is:
the alert controller is incorporated now.
Hopefully everything works fine.
Cheers, Felix
PS: May I draw your attention to this project: https://github.com/stonelasley/ionic-mocks
I have used a snippet from that project (it is marked). Maybe it would make sense to use this project?