search

lathonez / clicker

Ionic 2 + @angular/cli Seed Project : Angular2 + Typescript + Karma + Protractor + Travis
http://lathonez.com/2018/ionic-2-unit-testing/
MIT License
430 stars 137 forks source link

Ionic deeplinks #269

Closed hfwittmann closed 6 years ago

hfwittmann commented 6 years ago

Are there any plans to add support for deeplinks (with @IonicPage() and IonicPageModule ) ?

Felix PS I have something working, but can't achieve 100% coverage ( in a scenario for a page using a component)

hfwittmann commented 6 years ago

I have actually got a version to work, with 100& coverage, but it's little cumbersome ...

hfwittmann commented 6 years ago

I've now found a more elegant way, for an implementation of multi-language support. https://github.com/lathonez/clicker/issues/268 I would also be happy to supply a PR,

Cheers Felix

lathonez commented 6 years ago

Think this can be closed in favour of #268? Please re-open if not.

@hfwittmann - not sure if you're up for collaborating with @stonelasley on #271 - I have ~zero experience with ng-translate but happy to get stuck in with the CI / testing side.